Fixed code style and some tests

wireapp · Dec 9, 2024 · 15f3303 · 15f3303
1 parent c79f7ef
commit 15f3303
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 1 deletion.
diff --git a/app/src/main/kotlin/com/wire/android/media/audiomessage/ConversationAudioMessagePlayer.kt b/app/src/main/kotlin/com/wire/android/media/audiomessage/ConversationAudioMessagePlayer.kt
@@ -72,6 +72,7 @@ class ConversationAudioMessagePlayerProvider
     }
 }
 
+@Suppress("TooManyFunctions")
 class ConversationAudioMessagePlayer
 internal constructor(
     private val context: Context,

diff --git a/app/src/test/kotlin/com/wire/android/media/ConversationAudioMessagePlayerTest.kt b/app/src/test/kotlin/com/wire/android/media/ConversationAudioMessagePlayerTest.kt
@@ -40,6 +40,7 @@ import io.mockk.verify
 import kotlinx.coroutines.CompletableDeferred
 import kotlinx.coroutines.test.runTest
 import okio.Path
+import org.amshove.kluent.internal.assertEquals
 import org.junit.jupiter.api.Test
 
 @Suppress("LongMethod")
@@ -73,6 +74,11 @@ class ConversationAudioMessagePlayerTest {
                 assert(currentState != null)
                 assert(currentState!!.audioMediaPlayingState is AudioMediaPlayingState.SuccessfulFetching)
             }
+            awaitAndAssertStateUpdate { state ->
+                val currentState = state[testAudioMessageId]
+                assert(currentState != null)
+                assertEquals(currentState!!.wavesMask, Arrangement.WAVES_MASK)
+            }
             awaitAndAssertStateUpdate { state ->
                 val currentState = state[testAudioMessageId]
                 assert(currentState != null)
@@ -129,6 +135,11 @@ class ConversationAudioMessagePlayerTest {
                 assert(currentState != null)
                 assert(currentState!!.audioMediaPlayingState is AudioMediaPlayingState.SuccessfulFetching)
             }
+            awaitAndAssertStateUpdate { state ->
+                val currentState = state[testAudioMessageId]
+                assert(currentState != null)
+                assertEquals(currentState!!.wavesMask, Arrangement.WAVES_MASK)
+            }
             awaitAndAssertStateUpdate { state ->
                 val currentState = state[testAudioMessageId]
                 assert(currentState != null)
@@ -198,6 +209,11 @@ class ConversationAudioMessagePlayerTest {
                     assert(currentState != null)
                     assert(currentState!!.audioMediaPlayingState is AudioMediaPlayingState.SuccessfulFetching)
                 }
+                awaitAndAssertStateUpdate { state ->
+                    val currentState = state[firstAudioMessageId]
+                    assert(currentState != null)
+                    assertEquals(currentState!!.wavesMask, Arrangement.WAVES_MASK)
+                }
                 awaitAndAssertStateUpdate { state ->
                     val currentState = state[firstAudioMessageId]
                     assert(currentState != null)
@@ -282,6 +298,11 @@ class ConversationAudioMessagePlayerTest {
                     assert(currentState != null)
                     assert(currentState!!.audioMediaPlayingState is AudioMediaPlayingState.SuccessfulFetching)
                 }
+                awaitAndAssertStateUpdate { state ->
+                    val currentState = state[firstAudioMessageId]
+                    assert(currentState != null)
+                    assertEquals(currentState!!.wavesMask, Arrangement.WAVES_MASK)
+                }
                 awaitAndAssertStateUpdate { state ->
                     val currentState = state[firstAudioMessageId]
                     assert(currentState != null)
@@ -409,6 +430,11 @@ class ConversationAudioMessagePlayerTest {
                     assert(currentState != null)
                     assert(currentState!!.audioMediaPlayingState is AudioMediaPlayingState.SuccessfulFetching)
                 }
+                awaitAndAssertStateUpdate { state ->
+                    val currentState = state[testAudioMessageId]
+                    assert(currentState != null)
+                    assertEquals(currentState!!.wavesMask, Arrangement.WAVES_MASK)
+                }
                 awaitAndAssertStateUpdate { state ->
                     val currentState = state[testAudioMessageId]
                     assert(currentState != null)
@@ -494,7 +520,7 @@ class Arrangement {
     init {
         MockKAnnotations.init(this, relaxed = true)
 
-        every { wavesMaskHelper.getWaveMask(any<Path>()) } returns listOf()
+        every { wavesMaskHelper.getWaveMask(any<Path>()) } returns WAVES_MASK
         every { wavesMaskHelper.clear() } returns Unit
     }
 
@@ -529,4 +555,8 @@ class Arrangement {
     }
 
     fun arrange() = this to conversationAudioMessagePlayer
+
+    companion object {
+        val WAVES_MASK = listOf(1, 2, 3, 4, 5, 6, 7, 8, 9, 0)
+    }
 }