Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: commit strategy for mls commit missing reference [WPB-15871] 🍒 #3276

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 4, 2025

BugWPB-15871 [Android] Don't apply recover strategy 3 on mls-commit-missing-references

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Changed commit strategy from KEEP_AND_RETRY to DISCARD_AND_RETRY for mls-commit-missing-references error

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. type: bug / fix 🐞 👕 size: S 🚨 Potential breaking changes labels Feb 4, 2025
Copy link
Contributor Author

github-actions bot commented Feb 5, 2025

Test Results

3 418 tests  +3   3 310 ✅ +3   5m 27s ⏱️ -22s
  584 suites ±0     108 💤 ±0 
  584 files   ±0       0 ❌ ±0 

Results for commit 89c0707. ± Comparison against base commit 3f11819.

♻️ This comment has been updated with latest results.

Copy link
Contributor Author

github-actions bot commented Feb 5, 2025

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.87%. Comparing base (3f11819) to head (89c0707).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3276   +/-   ##
========================================
  Coverage    50.87%   50.87%           
========================================
  Files         1606     1606           
  Lines        57189    57189           
  Branches      5105     5105           
========================================
+ Hits         29093    29094    +1     
+ Misses       26081    26080    -1     
  Partials      2015     2015           

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f11819...89c0707. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Feb 5, 2025

Datadog Report

Branch report: fix/mls-missing-reference-commit-strategy-cherry-pick
Commit report: ffdbc21
Test service: kalium-jvm

✅ 0 Failed, 3310 Passed, 108 Skipped, 1m 0.05s Total Time

@vitorhugods vitorhugods enabled auto-merge February 5, 2025 15:40
Copy link

sonarqubecloud bot commented Feb 5, 2025

@vitorhugods vitorhugods added this pull request to the merge queue Feb 5, 2025
Merged via the queue into develop with commit 9ca21c1 Feb 5, 2025
23 checks passed
@vitorhugods vitorhugods deleted the fix/mls-missing-reference-commit-strategy-cherry-pick branch February 5, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. 🚨 Potential breaking changes 👕 size: S type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants