Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: do not swallow CancellationException [WPB-15412] #3264

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Jan 29, 2025

TaskWPB-15412 [Android] Re-throw CancellationException


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

do not swallow CancellationException

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara changed the title refactor: do not swallow CancellationException refactor: do not swallow CancellationException [WPB-15412] Feb 5, 2025
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. label Feb 5, 2025
Copy link

sonarqubecloud bot commented Feb 5, 2025

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Test Results

3 414 tests  ±0   3 306 ✅ ±0   5m 49s ⏱️ +29s
  584 suites ±0     108 💤 ±0 
  584 files   ±0       0 ❌ ±0 

Results for commit e4d6af4. ± Comparison against base commit b8408ba.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.81%. Comparing base (b8408ba) to head (e4d6af4).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3264      +/-   ##
===========================================
- Coverage    50.86%   50.81%   -0.05%     
===========================================
  Files         1606     1606              
  Lines        57183    57237      +54     
  Branches      5103     5107       +4     
===========================================
  Hits         29087    29087              
- Misses       26081    26134      +53     
- Partials      2015     2016       +1     

see 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8408ba...e4d6af4. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: refactor/throw-cancellation-exceptions
Commit report: a8d9996
Test service: kalium-jvm

✅ 0 Failed, 3306 Passed, 108 Skipped, 1m 2.74s Total Time

@MohamadJaara MohamadJaara added this pull request to the merge queue Feb 5, 2025
Merged via the queue into develop with commit 82347b7 Feb 5, 2025
23 checks passed
@MohamadJaara MohamadJaara deleted the refactor/throw-cancellation-exceptions branch February 5, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants