feat: cache contacts size (WPB-14523) #3259
Conversation
echoes-hq
bot
added
the
echoes/initiative: product-metrics-in-countly
| override suspend fun getContactsSize(): Either<StorageFailure, Int> = wrapStorageRequest { | ||
| userDAO.countUsers() | ||
| } |
There was a problem hiding this comment.
Just to be sure... I am not sure what a "contact" is. userDAO.countUsers() is returning a count of known users. These users not necessarily have connection requests, etc.
Edit: I scrolled down and saw the query is explicitly querying accepted connections, not only "known users".
Maybe getEstablishedConnectionsCount instead of getContactsSize ?
| countUsers: | ||
| SELECT COUNT(*) | ||
| FROM User WHERE connection_status == 'ACCEPTED'; |
There was a problem hiding this comment.
The name says countUsers, but it only counts accepted connections.
Maybe getEstablishedConnectionsCount.
Also, from a product point of view, should it also count known team mates, for example?
There was a problem hiding this comment.
It should count the number of user contacts.
|
Bencher Report| Branch | count-contacts |
| Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | microseconds (µs) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 679.47 |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 323,601.12 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,338,030.27 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 22,240.35 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3259 +/- ##
===========================================
- Coverage 53.90% 53.88% -0.03%
===========================================
Files 1303 1303
Lines 37396 37404 +8
Branches 3770 3771 +1
===========================================
- Hits 20159 20155 -4
- Misses 15828 15839 +11
- Partials 1409 1410 +1
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3302 Passed, 108 Skipped, 1m 2.91s Total Time |
|
|
||
| countUsers: | ||
| SELECT COUNT(*) |
There was a problem hiding this comment.
connection_status have no index and it can make this query very slow
There was a problem hiding this comment.
Added index on the connection_status column
|
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Description
Caching contacts size to use it for Countly events.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.