refactor: stop updating user info in the background [WPB-14826]

[MohamadJaara]

WPB-14826 [Android] Conversation list loading very slow after closing a conversation

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

can cause some extra calls in the background and block sync

Solutions

it is not needed and can be removed

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

• GitHub link to other pull request

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Test Results

3 405 tests   - 6   3 297 ✅  - 6   5m 6s ⏱️ -16s
  584 suites ±0     108 💤 ±0 
  584 files   ±0       0 ❌ ±0 

Results for commit 415a123. ± Comparison against base commit ab9c3ac.

This pull request removes 6 tests.

com.wire.kalium.logic.data.user.UserRepositoryTest ‑ givenAKnownFederatedUser_whenGettingFromDbAndCacheExpiredOrNotPresent_thenShouldRefreshItsDataFromAPI[jvm]
com.wire.kalium.logic.data.user.UserRepositoryTest ‑ givenAKnownOtherUser_whenGettingFromDbAndCacheExpiredOrNotPresent_thenShouldRefreshItsDataFromAPI[jvm]
com.wire.kalium.logic.data.user.UserRepositoryTest ‑ givenAKnownOtherUser_whenGettingFromDbAndCacheValid_thenShouldNOTRefreshItsDataFromAPI[jvm]
com.wire.kalium.logic.data.user.UserRepositoryTest ‑ givenAKnownSelfUser_whenGettingFromDbAndCacheExpiredOrNotPresent_thenShouldRefreshItsDataFromAPI[jvm]
com.wire.kalium.logic.data.user.UserRepositoryTest ‑ givenAKnownSelfUser_whenGettingFromDbAndCacheValid_thenShouldNOTRefreshItsDataFromAPI[jvm]
com.wire.kalium.logic.data.user.UserRepositoryTest ‑ givenSelfUserIsUnknown_whenObservingSelfUser_thenShouldAttemptToFetchIt[jvm]

♻️ This comment has been updated with latest results.

[github-actions]

Bencher Report

Branch	refactor/do-not-update-users-info-from-the-background
Testbed	ubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

• Latency (nanoseconds (ns))

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	microseconds (µs)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	📈 view plot ⚠️ NO THRESHOLD	676.31
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	📈 view plot ⚠️ NO THRESHOLD	337,944.63
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	📈 view plot ⚠️ NO THRESHOLD	1,348,477.65
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	📈 view plot ⚠️ NO THRESHOLD	21,786.33

🐰 View full continuous benchmarking report in Bencher

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 54.33%. Comparing base (ab9c3ac) to head (415a123).

Files with missing lines	Patch %	Lines
.../com/wire/kalium/logic/data/user/UserRepository.kt	0.00%	6 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3249      +/-   ##
===========================================
- Coverage    54.43%   54.33%   -0.10%     
===========================================
  Files         1271     1271              
  Lines        37100    37050      -50     
  Branches      3769     3758      -11     
===========================================
- Hits         20195    20132      -63     
- Misses       15484    15508      +24     
+ Partials      1421     1410      -11     

Files with missing lines	Coverage Δ
.../wire/kalium/logic/data/logout/LogoutRepository.kt	46.15% <ø> (+3.29%)	⬆️
.../com/wire/kalium/logic/data/user/UserRepository.kt	62.82% <0.00%> (-3.47%)	⬇️

... and 7 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab9c3ac...415a123. Read the comment docs.

[datadog-wireapp]

Datadog Report

Branch report: refactor/do-not-update-users-info-from-the-background
Commit report: 3b7038e
Test service: kalium-jvm

✅ 0 Failed, 3297 Passed, 108 Skipped, 1m 0.35s Total Time