Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add conversation folder [WPB-14628] #3233

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Jan 17, 2025

TaskWPB-14628 [Android] Conversation folder - Add new folder


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Add new conversation folder in local db

@Garzas Garzas self-assigned this Jan 17, 2025
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jan 17, 2025
Copy link
Contributor

github-actions bot commented Jan 17, 2025

Test Results

3 405 tests  +2   3 297 ✅ +2   5m 50s ⏱️ +31s
  584 suites ±0     108 💤 ±0 
  584 files   ±0       0 ❌ ±0 

Results for commit 5259a0d. ± Comparison against base commit 7611f05.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 17, 2025

@Garzas Garzas enabled auto-merge January 17, 2025 10:41
@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 17, 2025

Datadog Report

Branch report: feat/add-conversation-folder
Commit report: a0b07f3
Test service: kalium-jvm

✅ 0 Failed, 3297 Passed, 108 Skipped, 1m 2.79s Total Time

@Garzas Garzas added this pull request to the merge queue Jan 17, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 35.71429% with 18 lines in your changes missing coverage. Please review.

Project coverage is 54.46%. Comparing base (7611f05) to head (5259a0d).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ersation/folder/CreateConversationFolderUseCase.kt 0.00% 16 Missing ⚠️
...um/logic/feature/conversation/ConversationScope.kt 0.00% 1 Missing ⚠️
...o/conversation/folder/ConversationFolderDAOImpl.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3233      +/-   ##
===========================================
- Coverage    54.47%   54.46%   -0.02%     
===========================================
  Files         1269     1270       +1     
  Lines        36964    36992      +28     
  Branches      3745     3745              
===========================================
+ Hits         20137    20148      +11     
- Misses       15414    15431      +17     
  Partials      1413     1413              
Files with missing lines Coverage Δ
.../conversation/folders/ConversationFolderMappers.kt 72.54% <100.00%> (+7.33%) ⬆️
...nversation/folders/ConversationFolderRepository.kt 87.67% <100.00%> (+0.52%) ⬆️
...um/logic/feature/conversation/ConversationScope.kt 0.00% <0.00%> (ø)
...o/conversation/folder/ConversationFolderDAOImpl.kt 70.27% <66.66%> (-0.16%) ⬇️
...ersation/folder/CreateConversationFolderUseCase.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7611f05...5259a0d. Read the comment docs.

Merged via the queue into develop with commit 01522be Jan 17, 2025
23 checks passed
@Garzas Garzas deleted the feat/add-conversation-folder branch January 17, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 🚨 Potential breaking changes 👕 size: M type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants