Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignored connection stays in conversations list [#WPB-WPB-15212] #3231

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

sbakhtiarov
Copy link
Contributor

@sbakhtiarov sbakhtiarov commented Jan 15, 2025

BugWPB-15212 [Android]Connection request not removed after Ignored

https://wearezeta.atlassian.net/browse/WPB-15212

What's new in this PR?

Issues

Ignored connection stays in the conversation list until app restart.

Causes (Optional)

Connection status (PENDING) is not updated to IGNORED.

Solutions

Update connection status when ignore operation succeed.

@echoes-hq echoes-hq bot added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Jan 15, 2025
Copy link
Contributor

github-actions bot commented Jan 15, 2025

Test Results

3 395 tests  +2   3 287 ✅ +2   6m 2s ⏱️ +13s
  583 suites ±0     108 💤 ±0 
  583 files   ±0       0 ❌ ±0 

Results for commit 24fd2fe. ± Comparison against base commit 2a6796a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 15, 2025

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.46%. Comparing base (4362a23) to head (24fd2fe).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3231      +/-   ##
===========================================
- Coverage    54.52%   54.46%   -0.07%     
===========================================
  Files         1265     1268       +3     
  Lines        36890    36929      +39     
  Branches      3742     3744       +2     
===========================================
- Hits         20115    20112       -3     
- Misses       15362    15404      +42     
  Partials      1413     1413              
Files with missing lines Coverage Δ
...lium/logic/data/connection/ConnectionRepository.kt 65.60% <100.00%> (+0.55%) ⬆️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4362a23...24fd2fe. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 15, 2025

Datadog Report

Branch report: fix/hide-ignored-connection
Commit report: fd62444
Test service: kalium-jvm

✅ 0 Failed, 3287 Passed, 108 Skipped, 1m 3.95s Total Time

@sbakhtiarov sbakhtiarov added this pull request to the merge queue Jan 15, 2025
Merged via the queue into develop with commit 76697f1 Jan 15, 2025
23 checks passed
@sbakhtiarov sbakhtiarov deleted the fix/hide-ignored-connection branch January 15, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. 🚨 Potential breaking changes 👕 size: S type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants