Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backup): support export and import of backups on Web, iOS and Android [WPB-10575] #3228
feat(backup): support export and import of backups on Web, iOS and Android [WPB-10575] #3228
Changes from 6 commits
343bb40
ad0c886
a2e0e73
6e56b39
ad906f4
5f1dbfd
8c2873d
72cdd83
dbb7746
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be 'suspend' function? With the same pattern as for 'finalize' function, so that Kotlin clients can use it as a suspend function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making it
suspendable
adds a tiny bit of complexity, as we need to create a wrapper onjsMain
to return aPromise
instead.But, to be honest, I don't see any benefit in making it suspendable. It just doesn't do anything that requires suspending. Maybe we could switch to IO dispatcher within this function, but I expect whoever is calling this to already be on a worker thread.
For example, fetching stuff from DB, then calling
add
.We could really benefit from suspendable functions if we try to go fancy, like enqueueing the flushes to be done in parallel while we return from
add
, etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function should return some result to detect failures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed.
I guess mostly IO failures /
UnknownError(cause)
I guess. Sucks that JavaScript won't have IO failures at all, as everything is in memory 😆