Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: database logger [WPB-14608] #3227

Merged
merged 7 commits into from
Jan 15, 2025
Merged

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Jan 13, 2025

StoryWPB-14608 [Android] implement database logger


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

add database logger to monitor long-running quarries

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... label Jan 13, 2025
Copy link
Contributor

github-actions bot commented Jan 13, 2025

Test Results

3 393 tests   - 2   3 285 ✅  - 2   5m 40s ⏱️ -17s
  583 suites ±0     108 💤 ±0 
  583 files   ±0       0 ❌ ±0 

Results for commit b016dd9. ± Comparison against base commit 4362a23.

This pull request removes 2 tests.
com.wire.kalium.persistence.dao.client.ClientDAOTest ‑ givenPersistedClient_whenUpsertingTheSameExactClient_thenItShouldIgnoreAndNotNotifyOtherQueries[jvm]
com.wire.kalium.persistence.dao.client.ClientDAOTest ‑ givenPersistedClient_whenUpsertingUpdatedClient_thenItShouldBeSavedAndOtherQueriesShouldBeUpdated[jvm]

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 13, 2025

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 13, 2025

Datadog Report

Branch report: feat/database-logger
Commit report: 9f44691
Test service: kalium-jvm

✅ 0 Failed, 3285 Passed, 108 Skipped, 1m 2.49s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 49 lines in your changes missing coverage. Please review.

Project coverage is 54.46%. Comparing base (4362a23) to head (b016dd9).

Files with missing lines Patch % Lines
...n/com/wire/kalium/persistence/db/DebugExtension.kt 0.00% 36 Missing ⚠️
.../wire/kalium/persistence/db/UserDatabaseBuilder.kt 0.00% 5 Missing ⚠️
.../com/wire/kalium/logic/feature/debug/DebugScope.kt 0.00% 3 Missing ⚠️
...feature/debug/ObserveDatabaseLoggerStateUseCase.kt 0.00% 3 Missing ⚠️
...lium/logic/feature/debug/ChangeProfilingUseCase.kt 0.00% 1 Missing ⚠️
...m/wire/kalium/persistence/db/DebugExtension.jvm.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3227      +/-   ##
===========================================
- Coverage    54.52%   54.46%   -0.07%     
===========================================
  Files         1265     1268       +3     
  Lines        36890    36927      +37     
  Branches      3742     3744       +2     
===========================================
- Hits         20115    20111       -4     
- Misses       15362    15404      +42     
+ Partials      1413     1412       -1     
Files with missing lines Coverage Δ
...lium/logic/feature/debug/ChangeProfilingUseCase.kt 0.00% <0.00%> (ø)
...m/wire/kalium/persistence/db/DebugExtension.jvm.kt 0.00% <0.00%> (ø)
.../com/wire/kalium/logic/feature/debug/DebugScope.kt 0.00% <0.00%> (ø)
...feature/debug/ObserveDatabaseLoggerStateUseCase.kt 0.00% <0.00%> (ø)
.../wire/kalium/persistence/db/UserDatabaseBuilder.kt 79.53% <0.00%> (+1.69%) ⬆️
...n/com/wire/kalium/persistence/db/DebugExtension.kt 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4362a23...b016dd9. Read the comment docs.

@MohamadJaara MohamadJaara added this pull request to the merge queue Jan 15, 2025
Merged via the queue into develop with commit 2a6796a Jan 15, 2025
23 checks passed
@MohamadJaara MohamadJaara deleted the feat/database-logger branch January 15, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... 🚨 Potential breaking changes 👕 size: L type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants