fix: delay outgoing message before sync is finished [#WPB-15141] 🍒

[github-actions]

WPB-15141 [Android] After playtest, coming back to the app, getting a lot of "Cannot decrypt" system messages

This PR was automatically cherry-picked based on the following PR:

• fix: delay outgoing message before sync is finished [#WPB-15141] #3216

Original PR description:

---

https://wearezeta.atlassian.net/browse/WPB-15141

What's new in this PR?

Issues

Preconditions:

• Client was offline for a long time and has a lot of messages to sync.
• Conversation has self deleting messages with short expiration.

User opens the app, sync is started and user see some messages that cannot be decrypted in the conversation.

Causes

• Client receives a self delete message that expires before the sync is complete
• Client sends delete message to sender to confirm message deletion before sync is finished.
• Delete message is sent with old epoch value.
• Client receives 'mls-stale-message' error and re-joins conversation.
• All subsequent messages cannot be decrypted after re-join.

Solutions

Delay sending delete message until sync is complete. This ensures that message is sent with correct epoch value.

The issue has a broader context. Any message a client sends before sync is complete can cause re-join and break decryption. This should be covered as a part of: https://wearezeta.atlassian.net/browse/WPB-15262

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Test Results

3 401 tests  ±0   3 293 ✅ ±0   5m 43s ⏱️ -5s
  584 suites ±0     108 💤 ±0 
  584 files   ±0       0 ❌ ±0 

Results for commit f199a70. ± Comparison against base commit b304f30.

♻️ This comment has been updated with latest results.

[github-actions]

Bencher Report

Branch	fix/outgoing-message-before-sync-finished-cherry-pick
Testbed	ubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

• Latency (nanoseconds (ns))

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	microseconds (µs)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	📈 view plot ⚠️ NO THRESHOLD	680.52
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	📈 view plot ⚠️ NO THRESHOLD	602,104.32
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	📈 view plot ⚠️ NO THRESHOLD	1,340,574.92
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	📈 view plot ⚠️ NO THRESHOLD	21,626.01

🐰 View full continuous benchmarking report in Bencher

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 54.47%. Comparing base (b304f30) to head (f199a70).
Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
.../com/wire/kalium/logic/feature/debug/DebugScope.kt	0.00%	2 Missing ⚠️
.../wire/kalium/logic/feature/message/MessageScope.kt	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3220      +/-   ##
===========================================
- Coverage    54.48%   54.47%   -0.01%     
===========================================
  Files         1269     1269              
  Lines        36958    36962       +4     
  Branches      3745     3745              
===========================================
- Hits         20135    20134       -1     
- Misses       15410    15415       +5     
  Partials      1413     1413              

Files with missing lines	Coverage Δ
...eteEphemeralMessageForSelfUserAsReceiverUseCase.kt	94.28% <100.00%> (+0.16%)	⬆️
.../com/wire/kalium/logic/feature/debug/DebugScope.kt	0.00% <0.00%> (ø)
.../wire/kalium/logic/feature/message/MessageScope.kt	0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b304f30...f199a70. Read the comment docs.

[datadog-wireapp]

Datadog Report

Branch report: fix/outgoing-message-before-sync-finished-cherry-pick
Commit report: a9267ea
Test service: kalium-jvm

✅ 0 Failed, 3293 Passed, 108 Skipped, 1m 3.17s Total Time