Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move to folder [WPB-14627] #3213

Merged
merged 6 commits into from
Jan 13, 2025
Merged

feat: move to folder [WPB-14627] #3213

merged 6 commits into from
Jan 13, 2025

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Jan 7, 2025

TaskWPB-14627 [Android] Conversation folder - Move to folder


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • moving conversation to folder
  • fetch user folders when there is no favorite folder in current db
  • current folder information in conversation details

@Garzas Garzas self-assigned this Jan 7, 2025
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Test Results

3 395 tests  +8   3 287 ✅ +8   6m 17s ⏱️ +22s
  583 suites +2     108 💤 ±0 
  583 files   +2       0 ❌ ±0 

Results for commit 473b3d4. ± Comparison against base commit d54cc28.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 7, 2025

Datadog Report

Branch report: feat/move-to-folder
Commit report: 68dd47c
Test service: kalium-jvm

✅ 0 Failed, 3287 Passed, 108 Skipped, 1m 2.52s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 54.52%. Comparing base (d54cc28) to head (473b3d4).

Files with missing lines Patch % Lines
...ire/kalium/logic/data/conversation/Conversation.kt 0.00% 4 Missing ⚠️
...lium/logic/data/conversation/ConversationMapper.kt 50.00% 0 Missing and 2 partials ⚠️
...nversation/folders/ConversationFolderRepository.kt 0.00% 2 Missing ⚠️
...um/logic/feature/conversation/ConversationScope.kt 0.00% 1 Missing ⚠️
...ersation/folder/MoveConversationToFolderUseCase.kt 94.44% 0 Missing and 1 partial ⚠️
...o/conversation/folder/ConversationFolderDAOImpl.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3213      +/-   ##
===========================================
+ Coverage    54.49%   54.52%   +0.03%     
===========================================
  Files         1264     1265       +1     
  Lines        36858    36892      +34     
  Branches      3738     3743       +5     
===========================================
+ Hits         20085    20117      +32     
+ Misses       15363    15362       -1     
- Partials      1410     1413       +3     
Files with missing lines Coverage Δ
...e/conversation/folder/ObserveUserFoldersUseCase.kt 100.00% <100.00%> (+100.00%) ⬆️
...onversation/ConversationDetailsWithEventsMapper.kt 92.70% <100.00%> (+0.15%) ⬆️
...persistence/dao/conversation/ConversationMapper.kt 97.91% <100.00%> (+0.04%) ⬆️
...istence/dao/conversation/ConversationViewEntity.kt 97.95% <100.00%> (+0.08%) ⬆️
...um/logic/feature/conversation/ConversationScope.kt 0.00% <0.00%> (ø)
...ersation/folder/MoveConversationToFolderUseCase.kt 94.44% <94.44%> (ø)
...o/conversation/folder/ConversationFolderDAOImpl.kt 75.00% <0.00%> (ø)
...lium/logic/data/conversation/ConversationMapper.kt 57.78% <50.00%> (-0.25%) ⬇️
...nversation/folders/ConversationFolderRepository.kt 86.56% <0.00%> (ø)
...ire/kalium/logic/data/conversation/Conversation.kt 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d54cc28...473b3d4. Read the comment docs.

Comment on lines 1 to 11
DROP VIEW IF EXISTS ConversationDetails;

CREATE VIEW IF NOT EXISTS ConversationDetails AS
SELECT
Conversation.qualified_id AS qualifiedId,
CASE (Conversation.type)
WHEN 'ONE_ON_ONE' THEN User.name
WHEN 'CONNECTION_PENDING' THEN connection_user.name
ELSE Conversation.name
END AS name,
Conversation.type,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be 95

@Garzas Garzas requested a review from MohamadJaara January 13, 2025 11:31
@Garzas Garzas enabled auto-merge January 13, 2025 11:37
@Garzas Garzas added this pull request to the merge queue Jan 13, 2025
Merged via the queue into develop with commit 4362a23 Jan 13, 2025
23 checks passed
@Garzas Garzas deleted the feat/move-to-folder branch January 13, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 🚨 Potential breaking changes 👕 size: XL type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants