fix: Login to second device does not have MLS capabilities RC #WPB-14906 #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
typfel,
yamilmedina,
MohamadJaara,
vitorhugods,
Garzas and
saleniuk
|
yamilmedina
approved these changes
Dec 11, 2024
Garzas
approved these changes
Dec 11, 2024
vitorhugods
approved these changes
Dec 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3165 +/- ##
=====================================================
+ Coverage 54.14% 54.15% +0.01%
=====================================================
Files 1249 1249
Lines 36448 36448
Branches 3688 3688
=====================================================
+ Hits 19736 19740 +4
+ Misses 15288 15285 -3
+ Partials 1424 1423 -1
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3232 Passed, 107 Skipped, 1m 10.65s Total Time |
yamilmedina
deleted the
fix/login_to_second_device_does_not_have_mls_capabilities_rc
branch
echoes-hq
bot
added
the
echoes: product-roadmap/bug
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
* feat: harden ClientCapabilityDTO for api v7 * add tests * detekt * detekt * chore: disable folders update handler (#3161) * fix: Login to second device does not have MLS capabilities RC (#3165) * feat: add usecase to get team url (WPB-14872) (#3157) (#3168) * feat: add usecase to get team url * feat:detekt * feat: detekt * feat: detekt (cherry picked from commit abcd037) * chore: upgrade to cc3, fixes new_transaction in paralell (#3170) * test: add tests for old format parser in capabilities (#3173) * Update libs.versions.toml * Update UserPropertiesEventReceiver.kt * Update UserPropertiesEventReceiver.kt * Update UserPropertiesEventReceiverTest.kt * fix * fix tests * missing imports * fix circular dependency * Trigger CI * remove not needed dependency --------- Co-authored-by: Jakub Żerko <[email protected]> Co-authored-by: Yamil Medina <[email protected]> Co-authored-by: boris <[email protected]> Co-authored-by: Oussama Hassine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
When a user logs in to a second device after logging in to an MLS capable client, he does not have MLS capabilities on the second device: no previously created conversations and not MLS thumbprints in device details.
Causes (Optional)
field
creatorinConversationResponseDTOV3suppose to be nullable.Looks like we just forgot to add "?" to the field.
So when backend sends conversations with
creator = nullparser on android side fails.Solutions
Make
creatorfiled nullable. LaterConversationResponseDTOV3mapped intoConversationResponsewhich hasval creator: String?, so it should not add any problems :)