Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump avs 10.0.4 (WPB-11480) #3131

Closed
wants to merge 1 commit into from
Closed

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Nov 27, 2024

StoryWPB-11480 [Android] Simulcast Support & Automatic Quality Adjustments


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Broken 1:1 calls should be fixed in the new avs release.

Solutions

Bump avs to latest release


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Nov 27, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Nov 27, 2024
Copy link
Contributor

github-actions bot commented Nov 27, 2024

Test Results

3 327 tests  ±0   3 220 ✅ ±0   5m 2s ⏱️ -3s
  569 suites ±0     107 💤 ±0 
  569 files   ±0       0 ❌ ±0 

Results for commit f709947. ± Comparison against base commit 786a7b8.

♻️ This comment has been updated with latest results.

Copy link
Contributor

🐰 Bencher Report

Branchchore/bump-avsfixes
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
664,670.60
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
343,457,239.91
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,316,193,927.15
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,756,039.24
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.14%. Comparing base (786a7b8) to head (f709947).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3131      +/-   ##
===========================================
- Coverage    54.14%   54.14%   -0.01%     
===========================================
  Files         1249     1249              
  Lines        36281    36281              
  Branches      3658     3658              
===========================================
- Hits         19646    19643       -3     
- Misses       15223    15225       +2     
- Partials      1412     1413       +1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 786a7b8...f709947. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: chore/bump-avsfixes
Commit report: cced4f7
Test service: kalium-jvm

✅ 0 Failed, 3220 Passed, 107 Skipped, 37s Total Time

auto-merge was automatically disabled November 27, 2024 15:31

Pull request was closed

@yamilmedina yamilmedina deleted the chore/bump-avsfixes branch November 27, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. 👕 size: XS type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants