-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make some conversation models serializable, add serializer for Any primitive type [WPB-14433] #3130
Merged
MohamadJaara
merged 4 commits into
release/candidate
from
fix/add-serialization-for-conversation-models
Nov 27, 2024
Merged
fix: make some conversation models serializable, add serializer for Any primitive type [WPB-14433] #3130
MohamadJaara
merged 4 commits into
release/candidate
from
fix/add-serialization-for-conversation-models
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: unplanned
Any work item that isn’t part of the product or technical roadmap.
label
Nov 26, 2024
saleniuk
requested review from
a team,
m-zagorski,
yamilmedina,
MohamadJaara,
vitorhugods and
ohassine
and removed request for
a team
November 26, 2024 18:03
Quality Gate passedIssues Measures |
Datadog ReportBranch report: ✅ 0 Failed, 3160 Passed, 107 Skipped, 30.47s Total Time |
6 tasks
MohamadJaara
approved these changes
Nov 27, 2024
yamilmedina
approved these changes
Nov 27, 2024
MohamadJaara
deleted the
fix/add-serialization-for-conversation-models
branch
November 27, 2024 11:04
github-actions bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
…ny primitive type [WPB-14433] (#3130) * fix: add serializer for Any type holding primitive values * fix: add serialization for selected conversation models * fix detekt issues * fix test
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
…ny primitive type [WPB-14433] 🍒 (#3133) * fix: make some conversation models serializable, add serializer for Any primitive type [WPB-14433] (#3130) * fix: add serializer for Any type holding primitive values * fix: add serialization for selected conversation models * fix detekt issues * fix test * trigger build --------- Co-authored-by: Michał Saleniuk <[email protected]> Co-authored-by: Michał Saleniuk <[email protected]>
6 tasks
mastaab
added
echoes: product-roadmap/bug
Work contributing to resolve a bug not critical enough to have raised an incident.
and removed
echoes: unplanned
Any work item that isn’t part of the product or technical roadmap.
labels
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes: product-roadmap/bug
Work contributing to resolve a bug not critical enough to have raised an incident.
🚨 Potential breaking changes
👕 size: S
type: bug / fix 🐞
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When saving conversation menu state, models cannot be saved into bundle resulting in a crash.
Solutions
In order to save conversation menu state, models must be able to be saved, so the best way is to use kotlin serialization.
Any
type representing primitive types like boolean, string, int, float, etc.References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.