Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: primary key of conversation folder [WPB-14309] #3108

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Nov 15, 2024

TaskWPB-14309 Handle conversation folders and favorites from events


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • rearranged labeled conversation primary key

@Garzas Garzas requested a review from MohamadJaara November 15, 2024 14:07
@Garzas Garzas self-assigned this Nov 15, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Nov 15, 2024
@Garzas Garzas requested a review from saleniuk November 15, 2024 14:08
@Garzas Garzas enabled auto-merge November 15, 2024 14:15
@Garzas Garzas requested a review from yamilmedina November 15, 2024 14:15
Copy link
Contributor

github-actions bot commented Nov 15, 2024

Test Results

3 284 tests  ±0   3 177 ✅ ±0   5m 22s ⏱️ +10s
  559 suites ±0     107 💤 ±0 
  559 files   ±0       0 ❌ ±0 

Results for commit 2410728. ± Comparison against base commit d140d79.

♻️ This comment has been updated with latest results.

Copy link
Contributor

🐰 Bencher Report

Branchfix/folder-primary-key
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
674,892.00
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
616,701,546.89
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,351,191,957.20
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
22,270,950.95
🐰 View full continuous benchmarking report in Bencher

@Garzas Garzas added this pull request to the merge queue Nov 15, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.21%. Comparing base (d140d79) to head (2410728).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3108   +/-   ##
========================================
  Coverage    54.20%   54.21%           
========================================
  Files         1205     1205           
  Lines        35806    35806           
  Branches      3641     3641           
========================================
+ Hits         19410    19413    +3     
+ Misses       14993    14990    -3     
  Partials      1403     1403           

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d140d79...2410728. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/folder-primary-key
Commit report: d739c28
Test service: kalium-jvm

✅ 0 Failed, 3177 Passed, 107 Skipped, 42.25s Total Time

Merged via the queue into develop with commit eb66288 Nov 15, 2024
23 checks passed
@Garzas Garzas deleted the fix/folder-primary-key branch November 15, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 👕 size: XS type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants