-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: conversation folders [WPB-14309] #3106
Conversation
Bencher Report
Click to view all benchmark results
|
Datadog ReportBranch report: ✅ 0 Failed, 3177 Passed, 107 Skipped, 38.55s Total Time |
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/ConversationRepository.kt
Outdated
Show resolved
Hide resolved
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/ConversationMapper.kt
Outdated
Show resolved
Hide resolved
...nMain/kotlin/com/wire/kalium/logic/data/conversation/folders/ConversationFolderRepository.kt
Show resolved
Hide resolved
...nMain/kotlin/com/wire/kalium/logic/data/conversation/folders/ConversationFolderRepository.kt
Outdated
Show resolved
Hide resolved
...model/src/commonMain/kotlin/com/wire/kalium/network/api/authenticated/properties/LabelDTO.kt
Outdated
Show resolved
Hide resolved
persistence/src/commonMain/db_user/com/wire/kalium/persistence/ConversationFolders.sq
Show resolved
Hide resolved
persistence/src/commonMain/db_user/com/wire/kalium/persistence/ConversationFolders.sq
Outdated
Show resolved
Hide resolved
persistence/src/commonMain/db_user/com/wire/kalium/persistence/ConversationFolders.sq
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking solid! I have some questions and small improvements, here and there that we can take a look 🚀
...nMain/kotlin/com/wire/kalium/logic/data/conversation/folders/ConversationFolderRepository.kt
Outdated
Show resolved
Hide resolved
...ire/kalium/logic/feature/conversation/ObserveConversationListDetailsWithEventsUseCaseImpl.kt
Outdated
Show resolved
Hide resolved
...n/com/wire/kalium/logic/feature/conversation/folder/ObserveConversationsFromFolderUseCase.kt
Outdated
Show resolved
Hide resolved
...model/src/commonMain/kotlin/com/wire/kalium/network/api/authenticated/properties/LabelDTO.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Quality Gate passedIssues Measures |
FOREIGN KEY (conversation_id) REFERENCES Conversation(qualified_id) ON DELETE CASCADE ON UPDATE CASCADE, | ||
FOREIGN KEY (folder_id) REFERENCES ConversationFolder(id) ON DELETE CASCADE ON UPDATE CASCADE, | ||
|
||
PRIMARY KEY (conversation_id, folder_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be the other way around if you want to query conversations by folder
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
toModelConversationWithEvents
to parseConversationDetailsWithEvents
from dao to model