Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable x86 support [WPB-11427] 🍒 #3100

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 12, 2024

StoryWPB-11427 [Android] drop support for x86

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

disable x86 support

Testing

try to run the app on x86 emulator it should not install

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... type: feature ✨ 👕 size: S labels Nov 12, 2024
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. label Nov 20, 2024
Copy link
Contributor Author

github-actions bot commented Nov 20, 2024

Test Results

3 289 tests  ±0   3 182 ✅ ±0   5m 4s ⏱️ -6s
  561 suites ±0     107 💤 ±0 
  561 files   ±0       0 ❌ ±0 

Results for commit b42cebb. ± Comparison against base commit 3bf74f0.

♻️ This comment has been updated with latest results.

Copy link
Contributor Author

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.07%. Comparing base (3bf74f0) to head (b42cebb).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3100   +/-   ##
========================================
  Coverage    54.07%   54.07%           
========================================
  Files         1232     1232           
  Lines        36006    36006           
  Branches      3653     3653           
========================================
+ Hits         19469    19470    +1     
+ Misses       15128    15127    -1     
  Partials      1409     1409           

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bf74f0...b42cebb. Read the comment docs.

---- 🚨 Try these New Features:

@datadog-wireapp
Copy link

Datadog Report

Branch report: feat/disable-x86-support-cherry-pick
Commit report: 6b0f7b3
Test service: kalium-jvm

✅ 0 Failed, 3182 Passed, 107 Skipped, 35.9s Total Time

@vitorhugods vitorhugods added this pull request to the merge queue Nov 20, 2024
Merged via the queue into develop with commit 08c0cff Nov 20, 2024
22 checks passed
@vitorhugods vitorhugods deleted the feat/disable-x86-support-cherry-pick branch November 20, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... 👕 size: S type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants