-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Catch exception on Asset uploading [WPB-10700] 🍒 #3030
fix: Catch exception on Asset uploading [WPB-10700] 🍒 #3030
Conversation
* fix: Catch excecption on Asset uploading * Review fixes
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3030 +/- ##
===========================================
- Coverage 52.52% 52.52% -0.01%
===========================================
Files 1301 1301
Lines 50043 50047 +4
Branches 4663 4663
===========================================
+ Hits 26286 26287 +1
- Misses 21884 21888 +4
+ Partials 1873 1872 -1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3095 Passed, 107 Skipped, 12.58s Total Time |
This PR was automatically cherry-picked based on the following PR:
Original PR description:
What's new in this PR?
Issues
FileNotFoundException
on sending asset message.Causes (Optional)
Couldn't reproduce it, or find out the actual reason.
Solutions
Wrap it to
try catch
to at least not crash the app.