fix: update group state when fetching conversation during slow sync WPB-11247 #3029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: unplanned
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
MohamadJaara
approved these changes
Sep 25, 2024
|
It would be nice to add a test for this. Insert a conversation, insert it again with a different mls_group_state and assert that it is updated |
|
@MohamadJaara is release/candidate the right destination? |
ohh did not notice this one, the correct one should be "release/android-cycle-4.6" |
typfel
changed the base branch from
release/candidate
to
release/android-cycle-4.6
echoes-hq
bot
added
echoes: technical-roadmap/throughput
typfel
force-pushed
the
fix/mls-re-login-WPB-11247
branch
from
5f97cc2 to
dbdf3c1
Compare
|
Done |
vitorhugods
approved these changes
Sep 25, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
…PB-11247 (#3029) * fix: update group state when fetching conversation during slow sync * test: verify that group state is updated on re-insertion
6 tasks
typfel
added a commit
that referenced
this pull request
Sep 25, 2024
…PB-11247 (#3029) * fix: update group state when fetching conversation during slow sync * test: verify that group state is updated on re-insertion
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
…PB-11247 (#3029) (#3033) * fix: update group state when fetching conversation during slow sync * test: verify that group state is updated on re-insertion Co-authored-by: Jacob Persson <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
Sep 25, 2024
…PB-11247 (#3029) (#3033) * fix: update group state when fetching conversation during slow sync * test: verify that group state is updated on re-insertion Co-authored-by: Jacob Persson <[email protected]>
6 tasks
typfel
added a commit
that referenced
this pull request
Sep 25, 2024
…PB-11247 (#3029) (#3033) * fix: update group state when fetching conversation during slow sync * test: verify that group state is updated on re-insertion Co-authored-by: Jacob Persson <[email protected]>
typfel
added a commit
that referenced
this pull request
Sep 25, 2024
…PB-11247 (#3029) (#3033) * fix: update group state when fetching conversation during slow sync * test: verify that group state is updated on re-insertion Co-authored-by: Jacob Persson <[email protected]>
typfel
added a commit
that referenced
this pull request
Sep 27, 2024
…PB-11247 (#3029) (#3033) * fix: update group state when fetching conversation during slow sync * test: verify that group state is updated on re-insertion Co-authored-by: Jacob Persson <[email protected]>
typfel
added a commit
that referenced
this pull request
Sep 27, 2024
…PB-11247 (#3029) (#3033) * fix: update group state when fetching conversation during slow sync * test: verify that group state is updated on re-insertion Co-authored-by: Jacob Persson <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 27, 2024
…PB-11247 (#3029) (#3033) (#3037) * fix: update group state when fetching conversation during slow sync * test: verify that group state is updated on re-insertion Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jacob Persson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Group state isn't updated during the slow sync, which means MLS conversation will keep the
ESTABLISHEDstate even though they no longer exists inside CoreCrypto if we registered a new client.Causes
mls_group_stateis not included the "on conflict" clause.Solutions
Include it
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.