-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: stop handling team member add/removed events #2273
feat: stop handling team member add/removed events #2273
Conversation
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
…ember-join-leave-events # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/team/TeamRepository.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt # logic/src/commonTest/kotlin/com/wire/kalium/logic/data/team/TeamRepositoryTest.kt
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2273 +/- ##
=============================================
- Coverage 58.08% 58.06% -0.02%
Complexity 21 21
=============================================
Files 1087 1087
Lines 41147 40990 -157
Branches 3808 3800 -8
=============================================
- Hits 23901 23802 -99
+ Misses 15618 15562 -56
+ Partials 1628 1626 -2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done, just a small question on an unfinished comment 😅
logic/src/commonMain/kotlin/com/wire/kalium/logic/sync/receiver/UserEventReceiver.kt
Outdated
Show resolved
Hide resolved
This reverts commit e2f290b
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
team member join/removed events are not supported anymore by the server
Solutions
nuke the events
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.