fix: new 1on1 conversation not visible on list [WPB-5551] #2238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
New 1on1 conversations are not visible on conversation list until the user sends any message.
Causes (Optional)
After some recent updates with implementing protocols migration, it's now necessary for the user's field to match the 1on1 conversation id, otherwise it's not added to the list.
Resolving 1on1 conversations that executes protocol migration and results in filling in this field is executed when syncing conversations, creating a new one, accepting connection request or handling new connection, receiving MLS event, but has been missing for Proteus event.
The conversation was appearing after the user sent a message because then it executes which also resolves one on one conversation if can't be found (which also means when is not set properly).
Solutions
Execute also when Proteus event is received.
Testing
Test Coverage (Optional)
How to Test
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References