Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Showing E2EI dialog when feature disabled (WPB-5263) #2180

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

borichellow
Copy link
Contributor

What's new in this PR?

Issues

E2EI dialog is shown even when the MLS feature is disabled by feature flag.

Causes (Optional)

It was developed when the MLS feature flag was not in the project yet.

Solutions

in ObserveE2EIRequiredUseCase add checking the MLS feature flag.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@CLAassistant
Copy link

CLAassistant commented Nov 1, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Nov 1, 2023

Unit Test Results

   337 files   - 127     337 suites   - 127   11s ⏱️ - 4m 20s
1 823 tests  - 766  1 793 ✔️  - 692  30 💤  - 74  0 ±0 

Results for commit 0ac6613. ± Comparison against base commit bfcae0a.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

Merging #2180 (0ac6613) into develop (bfcae0a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             develop    #2180   +/-   ##
==========================================
  Coverage      57.97%   57.98%           
  Complexity        21       21           
==========================================
  Files           1065     1065           
  Lines          40472    40474    +2     
  Branches        3739     3740    +1     
==========================================
+ Hits           23465    23469    +4     
+ Misses         15395    15393    -2     
  Partials        1612     1612           
Files Coverage Δ
...m/logic/feature/user/ObserveE2EIRequiredUseCase.kt 88.00% <100.00%> (+1.04%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfcae0a...0ac6613. Read the comment docs.

@borichellow borichellow added this pull request to the merge queue Nov 3, 2023
Merged via the queue into develop with commit 821e139 Nov 3, 2023
@borichellow borichellow deleted the fix/showing_e2ei_dialog_when_feature_disabled branch November 3, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants