Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sync): bump slow sync version (WPB-5057) #2173

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

vitorhugods
Copy link
Member

Now that fetching of users is paginated and errors in this step are properly propagated, we should perform sync again to cover affected users.


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Now that fetching users is being paginated

Users in huge teams (1000+ users) can properly fetch all contacts during slow sync. But #2158 doesn't trigger slow sync again.

Solutions

Bump the SlowSync Version, so Kalium will trigger it again after updating the app.

Also, move it to be private inside the class, as there's no reason to make it publicly available like it was before.


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Now that fetching of users is paginated and errors in this step are properly propagated, we should perform sync again to cover affected users.
@vitorhugods vitorhugods enabled auto-merge (squash) October 26, 2023 13:02
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

Unit Test Results

   431 files     431 suites   1m 55s ⏱️
2 357 tests 2 259 ✔️ 98 💤 0

Results for commit 569d773.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 26, 2023

Datadog Report

All test runs d277f40 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2142 120 5m 29.03s Link
kalium-jvm 0 0 0 2259 98 10m 3.01s Link

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/candidate@5f7e64e). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             release/candidate    #2173   +/-   ##
====================================================
  Coverage                     ?   58.15%           
  Complexity                   ?       21           
====================================================
  Files                        ?     1010           
  Lines                        ?    37721           
  Branches                     ?     3434           
====================================================
  Hits                         ?    21938           
  Misses                       ?    14312           
  Partials                     ?     1471           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f7e64e...569d773. Read the comment docs.

@vitorhugods vitorhugods requested review from a team, yamilmedina, alexandreferris and ohassine and removed request for a team October 26, 2023 13:32
@vitorhugods vitorhugods merged commit 8f733ec into release/candidate Oct 26, 2023
@vitorhugods vitorhugods deleted the chore/bump-slow-sync-version branch October 26, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants