Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(e2ei): migrate mls-conversation after enrolling E2EI certificate (WPB-2928) #2164

Merged
merged 10 commits into from
Oct 25, 2023

Conversation

mchenani
Copy link
Contributor

@mchenani mchenani commented Oct 23, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

After issuing E2EI certificate, we need to pass the certificate to CoreCrypto and migrate all the conversation from Basic/Old-X509 certificate to the new issued one.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@mchenani mchenani changed the title feat(e2ei): migrate mls-conversation after enrolling E2EI certificate feat(e2ei): migrate mls-conversation after enrolling E2EI certificate (WPB-2928) Oct 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023

Unit Test Results

   463 files     463 suites   2m 56s ⏱️
2 576 tests 2 472 ✔️ 104 💤 0

Results for commit 84b2c06.

♻️ This comment has been updated with latest results.

Copy link
Member

@typfel typfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 24, 2023

Datadog Report

All test runs 5ee33c8 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1808 55 5m 16.07s Link
kalium-jvm 0 0 0 2472 104 26m 49.01s Link

@mchenani mchenani requested a review from ohassine October 25, 2023 11:15
@mchenani mchenani enabled auto-merge October 25, 2023 11:16
@mchenani mchenani added this pull request to the merge queue Oct 25, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2164 (84b2c06) into develop (872981a) will increase coverage by 0.07%.
Report is 7 commits behind head on develop.
The diff coverage is 76.33%.

@@              Coverage Diff              @@
##             develop    #2164      +/-   ##
=============================================
+ Coverage      57.88%   57.96%   +0.07%     
  Complexity        21       21              
=============================================
  Files           1059     1064       +5     
  Lines          40190    40309     +119     
  Branches        3722     3733      +11     
=============================================
+ Hits           23265    23366     +101     
- Misses         15314    15330      +16     
- Partials        1611     1613       +2     
Files Coverage Δ
...n/kotlin/com/wire/kalium/cryptography/MLSClient.kt 96.29% <ø> (+14.81%) ⬆️
...c/data/conversation/ConversationGroupRepository.kt 97.65% <100.00%> (+0.04%) ⬆️
...gic/data/conversation/MLSConversationRepository.kt 85.20% <100.00%> (+0.78%) ⬆️
...ation/NewGroupConversationSystemMessagesCreator.kt 91.81% <100.00%> (+0.90%) ⬆️
.../com/wire/kalium/logic/data/e2ei/E2EIRepository.kt 87.03% <100.00%> (+5.55%) ⬆️
...ature/connection/AcceptConnectionRequestUseCase.kt 100.00% <100.00%> (ø)
...ire/kalium/logic/feature/e2ei/CertificateStatus.kt 100.00% <100.00%> (ø)
.../wire/kalium/logic/feature/e2ei/E2eiCertificate.kt 100.00% <100.00%> (ø)
...um/logic/feature/e2ei/usecase/EnrollE2EIUseCase.kt 100.00% <100.00%> (ø)
.../feature/e2ei/usecase/GetE2EICertificateUseCase.kt 100.00% <100.00%> (ø)
... and 17 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 898cc8a...84b2c06. Read the comment docs.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 25, 2023
@mchenani mchenani added this pull request to the merge queue Oct 25, 2023
Merged via the queue into develop with commit b8dfcb5 Oct 25, 2023
15 checks passed
@mchenani mchenani deleted the feat/e2ei/rotate-conversation-with-e2ei-certificate branch October 25, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants