chore: architectural fitness functions - use case implementation visibility pt1. (ACOL-123)

[yamilmedina]

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

We have failing tests for use case visibility after introducing Konsist in:

• chore(epic): architectural fitness functions (ACOL-123) #2133

Causes (Optional)

Use case implementations can be instantiated from the outside world.

Solutions

Mark them as internal when possible or make their constructor internal to adhere to the rule.
Some tests will still fail, so I need to raise a part 2, or 3 after this.

Needs release

• chore(epic): architectural fitness functions (ACOL-123) #2133

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

How to test

Tests for the following checks, should NOT fail.

useCaseImplementationsShouldBeInternalOrHaveInternalConstructor[jvm] - com.wire.kalium.logic.architecture.UseCaseRulesTest -

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[github-actions]

Unit Test Results

102 files  102 suites   14s ⏱️
649 tests 559 ✔️ 89 💤 1 ❌

For more details on these failures, see this check.

Results for commit 02adee7.

♻️ This comment has been updated with latest results.

[datadog-wireapp]

Datadog Report

All test runs ae0a33d 🔗

❌ 2 Total Test Services: 1 Failed, 0 with New Flaky, 1 Passed

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Wall Time	Branch View
kalium-jvm	3	0	0	2429	52	11m 45.04s	Link
kalium-ios	0	0	0	560	89	3m 36.04s	Link

❌ Failed Tests (3)

• repositoriesShouldNotAccessFeaturePackageClasses[jvm] - com.wire.kalium.logic.architecture.LayerAccessRulesTest - Details

  Expand for error

   com.lemonappdev.konsist.core.exception.KoAssertionFailedException: Assert 'repositoriesShouldNotAccessFeaturePackageClasses' was violated (26 times). Invalid files:
   /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/auth/login/LoginRepository.kt (LoginRepository FileDeclaration)
   /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/call/CallMetadataProfile.kt (CallMetadataProfile FileDeclaration)
   /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/call/CallRepository.kt (CallRepository FileDeclaration)
   /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/call/CallingParticipantsOrder.kt (CallingParticipantsOrder FileDeclaration)
   /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/call/mapper/CallMapper.kt (CallMapper FileDeclaration)
   /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/client/E2EIClientProvider.kt (E2EIClientProvider FileDeclaration)
   /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/client/MLSClientProvider.kt (MLSClientProvider FileDeclaration)
   /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/client/UserClientRepositoryProvider.kt (UserClientRepositoryProvider FileDeclaration)
   /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/ConversationGroupRepository.kt (ConversationGroupRepository FileDeclaration)
   ...
  

• useCasesShouldNotAccessDaoLayerDirectly[jvm] - com.wire.kalium.logic.architecture.LayerAccessRulesTest - Details

  Expand for error

   com.lemonappdev.konsist.core.exception.KoAssertionFailedException: Assert 'useCasesShouldNotAccessDaoLayerDirectly' was violated (25 times). Invalid files:
   /__w/kalium/kalium/logic/src/androidMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt (UserSessionScope FileDeclaration)
   /__w/kalium/kalium/logic/src/androidMain/kotlin/com/wire/kalium/logic/feature/UserSessionScopeProviderImpl.kt (UserSessionScopeProviderImpl FileDeclaration)
   /__w/kalium/kalium/logic/src/appleMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt (UserSessionScope FileDeclaration)
   /__w/kalium/kalium/logic/src/appleMain/kotlin/com/wire/kalium/logic/feature/UserSessionScopeProviderImpl.kt (UserSessionScopeProviderImpl FileDeclaration)
   /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/ProteusClientProvider.kt (ProteusClientProvider FileDeclaration)
   /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/TimestampKeyRepository.kt (TimestampKeyRepository FileDeclaration)
   /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt (UserSessionScope FileDeclaration)
   /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/asset/ScheduleNewAssetMessageUseCase.kt (ScheduleNewAssetMessageUseCase FileDeclaration)
   /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/backup/BackupScope.kt (BackupScope FileDeclaration)
   ...
  

• useCasesShouldNotAccessNetworkLayerDirectly[jvm] - com.wire.kalium.logic.architecture.LayerAccessRulesTest - Details

  Expand for error

   com.lemonappdev.konsist.core.exception.KoAssertionFailedException: Assert 'useCasesShouldNotAccessNetworkLayerDirectly' was violated (24 times). Invalid files:
   /__w/kalium/kalium/logic/src/androidMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt (UserSessionScope FileDeclaration)
   /__w/kalium/kalium/logic/src/androidMain/kotlin/com/wire/kalium/logic/feature/UserSessionScopeProviderImpl.kt (UserSessionScopeProviderImpl FileDeclaration)
   /__w/kalium/kalium/logic/src/appleMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt (UserSessionScope FileDeclaration)
   /__w/kalium/kalium/logic/src/appleMain/kotlin/com/wire/kalium/logic/feature/UserSessionScopeProviderImpl.kt (UserSessionScopeProviderImpl FileDeclaration)
   /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/SessionManagerExt.kt (SessionManagerExt FileDeclaration)
   /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt (UserSessionScope FileDeclaration)
   /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/appVersioning/ObserveIfAppUpdateRequiredUseCase.kt (ObserveIfAppUpdateRequiredUseCase FileDeclaration)
   /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/auth/AuthenticationScope.kt (AuthenticationScope FileDeclaration)
   /__w/kalium/kalium/logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/auth/sso/SSOSettingsUseCase.kt (SSOSettingsUseCase FileDeclaration)
   ...