Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mls): add delete key-packages api (WPB-1003) #2151

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

mchenani
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Add a new api(on V5) to delete a batch key-packages.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

Unit Test Results

   458 files  ±0     458 suites  ±0   2m 18s ⏱️ -22s
2 552 tests ±0  2 448 ✔️ ±0  104 💤 ±0  0 ±0 

Results for commit 69b4db0. ± Comparison against base commit 49bd46f.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 18, 2023

Datadog Report

All test runs 59e8618 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1934 42 5m 32.01s Link
kalium-jvm 0 0 0 2448 104 11m 22.01s Link

@mchenani mchenani added this pull request to the merge queue Oct 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 18, 2023
@mchenani mchenani enabled auto-merge October 18, 2023 15:32
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Merging #2151 (69b4db0) into develop (49bd46f) will decrease coverage by 0.01%.
The diff coverage is 9.09%.

@@              Coverage Diff              @@
##             develop    #2151      +/-   ##
=============================================
- Coverage      57.82%   57.81%   -0.01%     
  Complexity        21       21              
=============================================
  Files           1059     1059              
  Lines          40156    40166      +10     
  Branches        3720     3720              
=============================================
+ Hits           23221    23223       +2     
- Misses         15327    15335       +8     
  Partials        1608     1608              
Files Coverage Δ
...api/base/authenticated/keypackage/KeyPackageApi.kt 100.00% <ø> (ø)
...um/network/api/v0/authenticated/KeyPackageApiV0.kt 7.69% <0.00%> (-2.31%) ⬇️
...um/network/api/v5/authenticated/KeyPackageApiV5.kt 55.55% <12.50%> (-19.45%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49bd46f...69b4db0. Read the comment docs.

@mchenani mchenani added this pull request to the merge queue Oct 19, 2023
Merged via the queue into develop with commit 3b1d9b2 Oct 19, 2023
15 checks passed
@mchenani mchenani deleted the feat/mls/add-delete-keypackages-api branch October 19, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants