-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(conversation-mls): add getMLSSelfConversationGroupId to ConversationDAO #2150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't you use the already existing method?
which one? couldn't find any. |
Codecov Report
@@ Coverage Diff @@
## develop #2150 +/- ##
=============================================
- Coverage 57.82% 57.82% -0.01%
Complexity 21 21
=============================================
Files 1058 1059 +1
Lines 40142 40156 +14
Branches 3719 3720 +1
=============================================
+ Hits 23212 23219 +7
- Misses 15323 15329 +6
- Partials 1607 1608 +1
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Added a new query to fetch the mlsSelfConversationGroupId.
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.