Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conversation-mls): add getMLSSelfConversationGroupId to ConversationDAO #2150

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

mchenani
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Added a new query to fetch the mlsSelfConversationGroupId.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Member

@typfel typfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't you use the already existing method?

@mchenani
Copy link
Contributor Author

Why can't you use the already existing method?

which one? couldn't find any.

@mchenani mchenani requested a review from typfel October 18, 2023 13:54
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

Unit Test Results

   458 files  ±0     458 suites  ±0   3m 2s ⏱️ +12s
2 552 tests +2  2 448 ✔️ ±0  104 💤 +2  0 ±0 

Results for commit 955fcc4. ± Comparison against base commit 91223ab.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

Merging #2150 (955fcc4) into develop (91223ab) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@              Coverage Diff              @@
##             develop    #2150      +/-   ##
=============================================
- Coverage      57.82%   57.82%   -0.01%     
  Complexity        21       21              
=============================================
  Files           1058     1059       +1     
  Lines          40142    40156      +14     
  Branches        3719     3720       +1     
=============================================
+ Hits           23212    23219       +7     
- Misses         15323    15329       +6     
- Partials        1607     1608       +1     
Files Coverage Δ
...um/persistence/dao/conversation/ConversationDAO.kt 100.00% <ø> (ø)
...ersistence/dao/conversation/ConversationDAOImpl.kt 66.82% <66.66%> (-0.01%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91223ab...955fcc4. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 18, 2023

Datadog Report

All test runs 939462b 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2128 66 4m 38.01s Link
kalium-jvm 0 0 0 2448 104 13m 18s Link

@mchenani mchenani added this pull request to the merge queue Oct 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 18, 2023
@mchenani mchenani enabled auto-merge October 19, 2023 06:58
@mchenani mchenani added this pull request to the merge queue Oct 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 19, 2023
@mchenani mchenani enabled auto-merge October 19, 2023 08:29
@mchenani mchenani added this pull request to the merge queue Oct 19, 2023
@mchenani mchenani removed this pull request from the merge queue due to a manual request Oct 19, 2023
@mchenani mchenani added this pull request to the merge queue Oct 19, 2023
Merged via the queue into develop with commit 49bd46f Oct 19, 2023
15 checks passed
@mchenani mchenani deleted the feat/mls/fetch-mls-self-groupid branch October 19, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants