fix: messages migration from proteus to mls [WPB-15149] 🍒 (#3219)

* Commit with unresolved merge conflicts

* test fixes

---------

Co-authored-by: Jakub Żerko <[email protected]>
Co-authored-by: Yamil Medina <[email protected]>

logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/conversation/mls/OneOnOneMigrator.kt

@@ -89,6 +89,11 @@ internal class OneOnOneMigratorImpl(
         return getResolvedMLSOneOnOne(user.id)
             .flatMap { mlsConversation ->
                 if (user.activeOneOnOneConversationId == mlsConversation) {
+                    kaliumLogger.d(
+                        "active one-on-one already resolved to MLS "
+                                + "${mlsConversation.toLogString()}, "
+                                + "user = ${user.id.toLogString()}"
+                    )
                     return@flatMap Either.Right(mlsConversation)
                 }
 
@@ -136,6 +141,10 @@ internal class OneOnOneMigratorImpl(
             // We can theoretically have more than one proteus 1-1 conversation with
             // team members since there was no backend safeguards against this
             proteusOneOnOneConversations.foldToEitherWhileRight(Unit) { proteusOneOnOneConversation, _ ->
+                kaliumLogger.d(
+                    "migrating proteus ${proteusOneOnOneConversation.toLogString()} " +
+                            "to MLS conv ${targetConversation.toLogString()}"
+                )
                 messageRepository.moveMessagesToAnotherConversation(
                     originalConversation = proteusOneOnOneConversation,
                     targetConversation = targetConversation

persistence/src/commonMain/db_user/com/wire/kalium/persistence/Messages.sq

@@ -91,7 +91,7 @@ CREATE TABLE MessageRestrictedAssetContent (
       asset_size INTEGER NOT NULL,
       asset_name TEXT NOT NULL,
 
-      FOREIGN KEY (message_id, conversation_id) REFERENCES Message(id, conversation_id) ON DELETE CASCADE,
+      FOREIGN KEY (message_id, conversation_id) REFERENCES Message(id, conversation_id) ON DELETE CASCADE ON UPDATE CASCADE,
       PRIMARY KEY (message_id, conversation_id)
 );
 

persistence/src/commonMain/db_user/com/wire/kalium/persistence/Reactions.sq

@@ -6,7 +6,7 @@ CREATE TABLE Reaction (
     sender_id TEXT AS QualifiedIDEntity NOT NULL,
     emoji TEXT NOT NULL,
     date TEXT NOT NULL,
-    FOREIGN KEY (message_id, conversation_id) REFERENCES Message(id, conversation_id) ON DELETE CASCADE,
+    FOREIGN KEY (message_id, conversation_id) REFERENCES Message(id, conversation_id) ON DELETE CASCADE ON UPDATE CASCADE,
     FOREIGN KEY (sender_id) REFERENCES User(qualified_id) ON DELETE CASCADE,
     PRIMARY KEY (message_id, conversation_id, sender_id, emoji)
 );

persistence/src/commonMain/db_user/migrations/94.sqm

@@ -0,0 +1,47 @@
+CREATE TABLE Reaction_temp AS
+SELECT * FROM Reaction;
+
+DROP TABLE Reaction;
+
+CREATE TABLE Reaction (
+    message_id TEXT NOT NULL,
+    conversation_id TEXT AS QualifiedIDEntity NOT NULL,
+    sender_id TEXT AS QualifiedIDEntity NOT NULL,
+    emoji TEXT NOT NULL,
+    date TEXT NOT NULL,
+    FOREIGN KEY (message_id, conversation_id) REFERENCES Message(id, conversation_id) ON DELETE CASCADE ON UPDATE CASCADE,
+    FOREIGN KEY (sender_id) REFERENCES User(qualified_id) ON DELETE CASCADE,
+    PRIMARY KEY (message_id, conversation_id, sender_id, emoji)
+);
+
+INSERT INTO Reaction(message_id, conversation_id, sender_id, emoji, date)
+SELECT message_id, conversation_id, sender_id, emoji, date
+FROM Reaction_temp;
+
+DROP TABLE Reaction_temp;
+
+CREATE INDEX reaction_sender_index ON Reaction(sender_id);
+CREATE INDEX reaction_emoji_index ON Reaction(emoji);
+
+CREATE TABLE MessageRestrictedAssetContent_temp AS
+SELECT * FROM MessageRestrictedAssetContent;
+
+DROP TABLE MessageRestrictedAssetContent;
+
+CREATE TABLE MessageRestrictedAssetContent (
+    message_id TEXT NOT NULL,
+    conversation_id TEXT AS QualifiedIDEntity NOT NULL,
+
+    asset_mime_type TEXT NOT NULL,
+    asset_size INTEGER NOT NULL,
+    asset_name TEXT NOT NULL,
+
+    FOREIGN KEY (message_id, conversation_id) REFERENCES Message(id, conversation_id) ON DELETE CASCADE ON UPDATE CASCADE,
+    PRIMARY KEY (message_id, conversation_id)
+);
+
+INSERT INTO MessageRestrictedAssetContent(message_id, conversation_id, asset_mime_type, asset_size, asset_name)
+SELECT message_id, conversation_id, asset_mime_type, asset_size, asset_name
+FROM MessageRestrictedAssetContent_temp;
+
+DROP TABLE MessageRestrictedAssetContent_temp;

persistence/src/commonTest/kotlin/com/wire/kalium/persistence/dao/message/MessageDAOTest.kt

@@ -27,10 +27,12 @@ import com.wire.kalium.persistence.dao.asset.AssetEntity
 import com.wire.kalium.persistence.dao.asset.AssetTransferStatusEntity
 import com.wire.kalium.persistence.dao.conversation.ConversationDAO
 import com.wire.kalium.persistence.dao.conversation.ConversationEntity
+import com.wire.kalium.persistence.dao.reaction.ReactionDAO
 import com.wire.kalium.persistence.dao.receipt.ReceiptDAO
 import com.wire.kalium.persistence.dao.receipt.ReceiptTypeEntity
 import com.wire.kalium.persistence.dao.unread.UnreadEventTypeEntity
 import com.wire.kalium.persistence.utils.IgnoreIOS
+import com.wire.kalium.persistence.utils.stubs.allMessageEntities
 import com.wire.kalium.persistence.utils.stubs.newConversationEntity
 import com.wire.kalium.persistence.utils.stubs.newRegularMessageEntity
 import com.wire.kalium.persistence.utils.stubs.newSystemMessageEntity
@@ -49,6 +51,7 @@ import kotlin.test.assertEquals
 import kotlin.test.assertFalse
 import kotlin.test.assertIs
 import kotlin.test.assertNotNull
+import kotlin.test.assertNull
 import kotlin.test.assertTrue
 import kotlin.time.Duration.Companion.days
 import kotlin.time.Duration.Companion.seconds
@@ -61,6 +64,7 @@ class MessageDAOTest : BaseDatabaseTest() {
     private lateinit var userDAO: UserDAO
     private lateinit var receiptDao: ReceiptDAO
     private lateinit var assetDao: AssetDAO
+    private lateinit var reactionDao: ReactionDAO
 
     private val conversationEntity1 = newConversationEntity("Test1")
     private val conversationEntity2 = newConversationEntity("Test2")
@@ -80,6 +84,7 @@ class MessageDAOTest : BaseDatabaseTest() {
         userDAO = db.userDAO
         receiptDao = db.receiptDAO
         assetDao = db.assetDAO
+        reactionDao = db.reactionDAO
     }
 
     @Test
@@ -2454,6 +2459,32 @@ class MessageDAOTest : BaseDatabaseTest() {
         assertEquals("3", result)
     }
 
+    @Test
+    fun givenAllTypesOfMessages_whenMovingToAnotherConversation_thenItSucceeds() = runTest {
+        // Given
+        insertInitialData()
+        val messages = allMessageEntities(conversationId = conversationEntity1.id, senderUserId = userEntity1.id)
+        val firstEmoji = "🫡"
+        messageDAO.insertOrIgnoreMessages(messages)
+        reactionDao.insertReaction(
+            messages.first().id,
+            messages.first().conversationId,
+            userEntity1.id,
+            Instant.DISTANT_PAST,
+            firstEmoji
+        )
+
+        // When
+        val exception = kotlin.runCatching {
+            messageDAO.moveMessages(conversationEntity1.id, conversationEntity2.id)
+        }.exceptionOrNull()
+
+        // Then
+        assertNull(exception, "Expected no exception but got: ${exception?.message}")
+        val result = messageDAO.getMessagesByConversationAndVisibility(conversationEntity2.id, 100, 0).first()
+        assertEquals(messages.size, result.size)
+    }
+
     private suspend fun insertInitialData() {
         userDAO.upsertUsers(listOf(userEntity1, userEntity2))
         conversationDAO.insertConversation(