Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(combinator): try_fold and verify_fold #685

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

Altair-Bueno
Copy link
Contributor

Closes #99

Implementation notes

Not sure if the documentation examples are good enough. In particular, I couldn't find any (non-nightly) simple examples for showcasing try_fold. Should we add something a bit more verbose or keep things simple?

src/combinator/multi.rs Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jan 10, 2025

Pull Request Test Coverage Report for Build 12715974807

Details

  • 0 of 85 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-1.1%) to 40.278%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/combinator/multi.rs 0 85 0.0%
Files with Coverage Reduction New Missed Lines %
src/token/mod.rs 1 75.0%
Totals Coverage Status
Change from base Build 12702423757: -1.1%
Covered Lines: 1274
Relevant Lines: 3163

💛 - Coveralls

src/combinator/multi.rs Outdated Show resolved Hide resolved
src/combinator/multi.rs Outdated Show resolved Hide resolved
src/combinator/multi.rs Outdated Show resolved Hide resolved
- Rename {try,verify}_fold_impl functions
- remove doc alias
@epage
Copy link
Collaborator

epage commented Jan 10, 2025

btw I'm generally fine having commits squashed during review and much prefer the commits to match user-facing changes (so a fix meaning something in master is fixed, not fixed within the same PR)

@epage epage merged commit 83e2b58 into winnow-rs:main Jan 10, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failable fold support (ie try_fold)
3 participants