Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comb): Deprecate top-level opaque impls #675

Merged
merged 5 commits into from
Jan 6, 2025
Merged

Conversation

epage
Copy link
Collaborator

@epage epage commented Jan 6, 2025

This is to avoid cluttering up the main docs page with irrelevant information.

We could hide these but then you can't inspect them if needed (e.g. to verify they implement a trait).

I didn't do this to Repeat because it has functionality on it and so is less opaque.

This is a cherry-pick of #673

@epage epage enabled auto-merge January 6, 2025 21:01
@epage epage merged commit c20aba1 into winnow-rs:v0.6-main Jan 6, 2025
16 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12640262380

Details

  • 0 of 11 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 41.469%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 0 11 0.0%
Totals Coverage Status
Change from base Build 12607251300: 0.03%
Covered Lines: 1276
Relevant Lines: 3077

💛 - Coveralls

@epage epage deleted the cherry branch January 6, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants