Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update patch for libzstd version 1.5.6 #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

macintoshplus
Copy link
Contributor

To build the libzstd, a patch must be applied to change the output filename.

With v1.5.6, the patch does not work due to changes in the target file and another bug.

This patch is proposed to replace the actual patch. I have been building version 1.5.6 for ARM64.

@cmb69
Copy link
Member

cmb69 commented Dec 4, 2024

Thanks for the PR! It's overdue that we ship updated zstd.

I think we can do without having to drop support for somewhat older zstd versions, though. The fix for the broken resource compilation in zstd 1.5.6 (facebook/zstd#3999) could be moved to the builder like demonstrated in that ticket (works for 1.4.8 and 1.5.6 and likely other versions too). To be able to cleanly apply the existing patch, we could modify it to use only two lines of context; that seems to be sufficient in this case.

And in the long run we should use pkg-config for building PHP on Windows; that would allow to migrate away from any particular naming convention, so we have to apply fewer patches.

@cmb69 cmb69 mentioned this pull request Dec 4, 2024
@cmb69
Copy link
Member

cmb69 commented Dec 4, 2024

See #33 for an alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants