Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom animation #199
base: master
Are you sure you want to change the base?
Custom animation #199
Changes from 19 commits
949a671
6d5eb1b
de42ade
f06f619
7cb2323
32cd086
4ad4474
c026e39
484e557
fcccf4d
c7253d1
dfff735
db33de8
7b12074
f7c0e24
35b2585
9c7ddcf
5e63c8e
26c0e2f
1a5e6d3
01aa821
e87ed76
07c131f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally prefer using either
IEnumerable<T>
or justList<T>
, don't see a point in usingIList<T>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So IMHO IList
<T>
is preferable toList<T>
so we're not forcing the specific implementation ofList
.IEnumerable
may be okay if I'm not using anyIList
methods. Sometimes you can end up with LINQ having to provide functionality that is already there, an example isCount
.IList
provides a property forCount
,IEnumerable
doesn't, so if you need to count the items you have to get LINQ to iterate over theIEnumerable
for you usingCount()
rather than just using theCount
property that would be there if it were anIList
.The same is true for
Any()
, rather thanCount > 0
. This isn't as bad asCount()
asAny()
just needs to read one item from theIEnumerable
, but it is still less efficient than theCount
property.I'll see what I break if I change to
IEnumerable
and get back to you.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a lot of use of indexing, so it has to be
List
orIList
. Personally I preferIList
as this means if we ever wanted to swap the implementation fromList
to a similar collection that still implementsIList
we would know it would definitely not break any existing code.