Reworked the entire API layer to use DTO classes and use the factory pattern #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of hacky creation of the client.
|
Kudos, SonarCloud Quality Gate passed! |
StijnOostdam
approved these changes
Jun 7, 2021
|
|
||
| public string AuthenticationToken { get; set; } | ||
|
|
||
| public string BaseUrl => $"http://{Ip}:{Port}/api/v1/{AuthenticationToken}/"; |
There was a problem hiding this comment.
What is the best location or this base url? Maybe in the client class?
| @@ -0,0 +1,24 @@ | |||
| namespace Winleafs.Api.DTOs.Shared | |||
| { | |||
| public class WriteObjectDto | |||
There was a problem hiding this comment.
Use full names for variables and parameters
| @@ -0,0 +1,24 @@ | |||
| namespace Winleafs.Api.DTOs.Shared | |||
| { | |||
| public class WriteObjectDto | |||
There was a problem hiding this comment.
Can this be more specific or is it used for all writes? Then maybe make this a base class and make one or more derived classes, which then has, for example, the ExtControlVersion property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.