Is it doing string comparison not boolean evaluation?

willGraham01 · Mar 27, 2024 · e0b6a05 · e0b6a05
1 parent 98a570f
commit e0b6a05
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/.github/workflows/fetch_sha.yml b/.github/workflows/fetch_sha.yml
@@ -40,15 +40,15 @@ jobs:
         with:
           result-encoding: string
           script: |
-            if (!${{ needs.check-if-pr-comment.outputs.is-pr-comment }}) {
-              return context.sha;
+            if (${{ needs.check-if-pr-comment.outputs.is-pr-comment }} == "true") {
+              const { data: pr } = await github.rest.pulls.get({
+                owner: context.issue.owner,
+                repo: context.issue.repo,
+                pull_number: context.issue.number,
+              });
+              return pr.head.sha;
             };
-            const { data: pr } = await github.rest.pulls.get({
-              owner: context.issue.owner,
-              repo: context.issue.repo,
-              pull_number: context.issue.number,
-            });
-            return pr.head.sha;
+            return context.sha;
 
   report-sha:
     name: Report SHA that was recovered