Stop using Guzzle's 'sink' option #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a bug in the Guzzle cache middleware that means we have to switch to saving the file responses (for images) in the response handler rather than leaving it to Guzzle. This is a workaround until the bug is fixed. Bug: T265660
samwilson
force-pushed
the
fix-image-caching
branch
from
b2148f9 to
d12829c
Compare
cimurah
reviewed
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug in the Guzzle cache middleware that means we have
to switch to saving the file responses (for images) in the response
handler rather than leaving it to Guzzle.
This is a workaround until the bug is fixed.
Bug: T265660