Encode article title in WikiWho API access #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I forgot to fix a test (and write a new one). 😔 I'll do this in the morning (~8 hours), if it hasn't been resolved by then. |
The article title is not URL encoded when the WikiWho API URL is being constructed (Api.js#getAjaxURL). This causes any article with a question mark to have a URL containing query parameters starting wherever the question mark is.
|
Should be fixed now. I've ensured that the test here now uses encoded paths and also added a test to check if special characters are encoded. |
MusikAnimal
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The article title is not URL encoded when the WikiWho API URL is being constructed (Api.js#getAjaxURL). This causes any article with a question mark to have a URL containing query parameters starting wherever the question mark is.
Most prominent issue is when viewing an article with a title that ends with a question mark, where the title without the question mark removed (practically always a redirect) shows up instead of the actual article.
Revision ID left unencoded since it's expected to be a number, which won't have any special characters that need encoding.
Initially reported by Your Power on Discord.