Dockerfile: Add group by id not name

When a group already exists with the specified gid, usermod with -f will silently added the group with a default new gid. So worker ends up with an extra useless group rather than the one specified. Signed-off-by: Chris Harding <[email protected]>
whipper-team · May 29, 2024 · b40ec2d · b40ec2d
1 parent a4b9742
commit b40ec2d
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/Dockerfile b/Dockerfile
@@ -56,7 +56,7 @@ RUN ldconfig
 # add user (+ group workaround for ArchLinux)
 RUN useradd -m worker --uid ${uid} -G cdrom \
     && if [ -n "${optical_gid}" ]; then groupadd -f -g "${optical_gid}" optical \
-    && usermod -a -G optical worker; fi \
+    && usermod -a -G "${optical_gid}" worker; fi \
     && mkdir -p /output /home/worker/.config/whipper \
     && chown worker: /output /home/worker/.config/whipper
 VOLUME ["/home/worker/.config/whipper", "/output"]