Build: Replace Node Sass with Dart Sass #2457
Merged
+377
−2,015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically: * Package: Temporarily replaced WET dependency (github:wet-boew/wet-boew#v4.0.83) with wet-boew/wet-boew#9840's branch * Gruntfile: Temporarily disabled "check-wet-version" task (to avoid a version mismatch)
Replaces GCWeb's direct Sass dependencies (i.e. not from its WET dependency): * Package: Replace node-sass with sass (aka Dart Sass) * Gruntfile: Update sass variable's requirement from "node-sass" to "sass"
EricDunsworth
temporarily deployed
to
github-ci
GitHub Actions
Inactive
|
Marking this as a draft since I haven't tried going over its outputted CSS at all and since the second commit technically makes it unmerge-able (only point of it was to prove a GCWeb+WET Dart Sass setup is able to successfully build). |
duboisp
reviewed
Dec 23, 2024
|
I tried to build on a fresh system ( But it does work on my other system. I am able to successfully compile with cc @Garneauma |
|
Pre-approved upon successful review. |
This reverts commit b20b569.
EricDunsworth
temporarily deployed
to
github-ci
GitHub Actions
Inactive
Garneauma
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimum changes needed to get it to successfully build.
Contains countless deprecation warnings, but those can be dealt with in the future.
GCWeb port of wet-boew/wet-boew#9840.