Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main: fix word-break issue for long words in small screens #2450

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Main: fix word-break issue for long words in small screens #2450

merged 1 commit into from
Jan 15, 2025
+18 −2

Conversation

Garneauma
Copy link
Contributor

No description provided.

@Garneauma
Copy link
Contributor Author

Pre-approved upon successful review and addition of working example.

duboisp
duboisp approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and manually tested a very long word that was overflowing outside the main container. It does work as expected.

Propose this commit message for merging this: Patch - Core - Fix word-break issue in the main section for long words on small screens

duboisp
duboisp requested changes Jan 14, 2025
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add an example in the "templates/content-page/conten-en.html by adding a very long word in one of the paragraph inside.

@duboisp duboisp assigned Garneauma and unassigned duboisp Jan 14, 2025
@Garneauma
Copy link
Contributor Author

@duboisp Working example added.

duboisp
duboisp approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good,

@duboisp duboisp merged commit 7d6fd80 into wet-boew:master Jan 15, 2025
1 check passed
@duboisp duboisp added this to the v16.1.0 milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duboisp duboisp duboisp approved these changes

Assignees

@Garneauma Garneauma

Labels
None yet
Projects
None yet
Milestone
v16.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Garneauma @duboisp