Most requested: display items in columns #2446
Conversation
|
Pre-approved upon successful review. |
There was a problem hiding this comment.
Question: see inline.
Note: I reviewed + tested locally and I do confirm the items are re-ordered vertically instead of horizontally.
This change is very perceptible and I do evaluate if as a major change because of the visual change. Additional communication might be required prior to apply this change.
@Ricokola please review and take actions to manage the breaking change. Thanks
| main:not(.container) .gc-most-requested, | ||
| div:not(.container) .gc-most-requested { |
There was a problem hiding this comment.
This don't seem to work as expected. I moved the "gc-most-requested" inside a component and the style was still applied.
Also, I am unable to observe the effect of that style in FF neither in Chrome. What it does? Should we add an additional working example for that edge case?
There was a problem hiding this comment.
Alternatively, you can add a style to break bad implementation like undo:
- the h2 float
- col-count set to 1
- No background color.
CSS selector sample: .container .gc-most-request
| main:not(.container) .gc-most-requested, | ||
| div:not(.container) .gc-most-requested { |
There was a problem hiding this comment.
| main:not(.container) .gc-most-requested, | |
| div:not(.container) .gc-most-requested { | |
| :not(.container) .gc-most-requested { |
| main:not(.container) .gc-most-requested, | ||
| div:not(.container) .gc-most-requested { |
There was a problem hiding this comment.
Alternatively, you can add a style to break bad implementation like undo:
- the h2 float
- col-count set to 1
- No background color.
CSS selector sample: .container .gc-most-request
This PR changes the distribution of Most requested items from top to bottom and from left to right instead of from left to right and top to bottom.
Before:
1 2
3 4
5 6
After:
1 4
2 5
3 6
Changes related to WET-488