Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update steps.css #2441

Merged
merged 9 commits into from
Nov 6, 2024
Merged

Update steps.css #2441

merged 9 commits into from
Nov 6, 2024

Conversation

Christopher-O
Copy link
Contributor

Clear and simple explanation of the change/update:

Additional CSS and example added to support basic use (for numbers 2 to 10) of the start attribute for ordered (ol) lists as the CSS design uses a CSS count method to display the numbers and not the generated numbers from the html element.

Future design could include a javascript to allow any start number to exist.

The impact on the sponsored department (CRA) for that change/update:

No impact.

The impact on the public for that change/update:

More flexibility of using the design in various situations.

@Christopher-O
Update steps.css
d6a526f 
Clear and simple explanation of the change/update:

Additional CSS and example added to support basic use (for numbers 2 to 10) of the start attribute for ordered (ol) lists as the CSS design uses a CSS count method to display the numbers and not the generated numbers from the html element. 

Future design could include a javascript to allow any start number to exist.  

The impact on the sponsored department (CRA) for that change/update:

No impact

The impact on the public for that change/update:

More flexibility of using the design in various situations.
@Christopher-O
Update index.html
b51c49d 
Added extended functionality example for use of start attribute for steps
@Christopher-O
Update index-fr.html
5c60a12 
Added extended functionality example using start attribute for steps
@Christopher-O
Update steps-doc-en.html
fe76ee2 
Added start attribute code
@Christopher-O
Update steps-doc-fr.html
12a4bd9 
Added code snippet for start attribute
@Christopher-O
Update meta.md
882a404 
Added updated feature to list
duboisp
duboisp previously requested changes Nov 6, 2024
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the following working example

Step that are starting at:

  • step 2
  • step 4
  • step 5
  • step 6
  • step 7
  • step 8
  • step 9

FYI - I am going to add those working example.

@duboisp
Copy link
Member

duboisp commented Nov 6, 2024

@Garneauma for your final review. Thanks

From my point of view, it should be good now once the final review is completed.

Garneauma
Garneauma requested changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@Garneauma Garneauma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please move the "Start attribute' section in the documentation page to be under the "Configuration options" section.
  • Please add the attribute "altLangPage" to the documentation pages.

méli-mélo/2021-05-steps/index-fr.html Outdated Show resolved Hide resolved
méli-mélo/2021-05-steps/index-fr.html Outdated Show resolved Hide resolved
méli-mélo/2021-05-steps/steps-doc-fr.html Outdated Show resolved Hide resolved
@duboisp
Copy link
Member

duboisp commented Nov 6, 2024

@Garneauma I made the requested change and more the following:

  • Added language toggle in the doc (EN/FR)
  • Fixed the doc + working example to say it start a steps from 2 to 9, instead of 2 to 10
  • In the first working example (FR & EN) for the start step, I changed the heading level coded inside the list item

@Garneauma Garneauma merged commit e2fa333 into wet-boew:master Nov 6, 2024
1 check passed
@Christopher-O Christopher-O mentioned this pull request Nov 15, 2024
Open
SebastianBurke added a commit to SebastianBurke/GCWeb that referenced this pull request Nov 27, 2024
@SebastianBurke
Fulfilled Changes Requested
b5538fd 
Feedback area: adding a11y assessment performed by CRA (wet-boew#2433)

Patch - Méli-mélo: DataTable Utilities (wet-boew#2438)

* Initial Commit of 2024-10-datatable-utilities

* Adjustment to the jeckell html pages as the Javascript Didn't load

* Update to the meta.md

* Fix to toFrenchMoney Function failing under  'use strict' and Some fixes to the Sample HTML pages

* Fix for French Totals coming back as NaN

* Implemented wet-boew team Accesibility changes to sample pages + added css to replace <strong> on the Totals

* 1.1.0 - Wet-Boew Fixes + French Translation of Examples Page

* Fixed a Typo

* Added the URL Column to the Raw Data

* Updated Implementation Plan

* Fixed typo in implementation Plan

---------

Co-authored-by: Steve Bourgeois <[email protected]>

Patch - GC Home Page: Reduced Doormats and added all services button (wet-boew#2434)

* GC Home Page: Reduced Doormats and added all services button

* Home: updating All services button styling

---------

Co-authored-by: Marc-André Garneau <[email protected]>

Patch - Steps Méli-mélo: Update steps.css (wet-boew#2441)

* Update steps.css

Clear and simple explanation of the change/update:

Additional CSS and example added to support basic use (for numbers 2 to 10) of the start attribute for ordered (ol) lists as the CSS design uses a CSS count method to display the numbers and not the generated numbers from the html element.

Future design could include a javascript to allow any start number to exist.

The impact on the sponsored department (CRA) for that change/update:

No impact

The impact on the public for that change/update:

More flexibility of using the design in various situations.

* Update index.html

Added extended functionality example for use of start attribute for steps

* Update index-fr.html

Added extended functionality example using start attribute for steps

* Update steps-doc-en.html

Added start attribute code

* Update steps-doc-fr.html

Added code snippet for start attribute

* Update meta.md

Added updated feature to list

* Méli-mélo 2021-05-steps - Add working example for custom starting step

* Méli-mélo 2021-05-steps - Typo fix for custom starting steps

* Méli-mélo 2021-05-steps - Typo fix for custom starting steps

---------

Co-authored-by: Pierre Dubois <[email protected]>

Release v15.7.1 (wet-boew#2443)

Patch - Update _base.scss (wet-boew#2444)

* Update _base.scss

Clear and simple explanation of the change/update:

Updated input elements to be invisible simply by using opacity: 0 and z-index:2 in order for inputs to be selected by Dragon Naturally Speaking adaptive technology voice reader

Added fallback to show focus of checkboxes and radio buttons and selection of radio buttons in Windows high contrast mode.

The impact on the sponsored department (CRA) for that change/update:

Improved accessibility for users of the adaptive technology or visual mode

The impact on the public for that change/update:

No change for current use cases, but allows easier selection of radio button and checkboxes using Dragon Naturally Speaking, and provides proper focus in high contrast mode when using keyboard and selecting radio buttons

* removed test provisional class extension

* adding margin so input is nested inside design

* Adding documentation and fixing hidden checkbox hover

---------

Co-authored-by: Marc-André Garneau <[email protected]>

Requested changes complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garneauma Garneauma Garneauma approved these changes

@duboisp duboisp duboisp left review comments

Assignees

@duboisp duboisp

Labels
None yet
Projects
None yet
Milestone
v15.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Christopher-O @duboisp @Garneauma @ouafaaetta