wb-tables DataTable Utilities

[bozzit]

Utility Plugin that adds data formatting options and Table Totals

as Per Documentation: https://bozzit.github.io/GCWeb/m%C3%A9li-m%C3%A9lo/2024-10-datatable-utilities/index-eng.html

[Garneauma]

Pre-approved upon successful review and passing of the méli-mélo checklist.

To do (for WET-BOEW team):

• Create meta.md file
• Create permanent URL

[Garneauma]

Thank you for your contribution @bozzit ! Below are a few comments and suggestions:

• Please remove all debug messages (or comment out).
• Please rename index-eng.html to index-en.html and index-fra.html to index-fr.html to keep it consistent with the rest of the project.
• Suggestion: create a separate documentation page for all the options instead of having them in the JS file. You could follow the table under "Configuration options" in the Fieldflow component. No need to have it translated.
• Please add an implementation plan item: "Produce accessibility conformance report".
• I don't see a working example for the following option: wb-col-cur-thousand.

[bozzit]

for Debug messages you mean : debugMsg(... ? Those only get printed IF you pass data-wb-tables-utility="{"debug":true, to the component. I can amend the example to not use debug: true if you wish but I believe that having the ability to print debug messages on demand is a nice to have.

Let me know

[Garneauma]

for Debug messages you mean : debugMsg(... ? Those only get printed IF you pass data-wb-tables-utility="{"debug":true, to the component. I can amend the example to not use debug: true if you wish but I believe that having the ability to print debug messages on demand is a nice to have.

Let me know

OK no problem about the debug messages. Sorry did not notice it was only with that option.

[bozzit]

So once I have made the requested Changes, how do I go about submitting the changes? New Pull request? OR is there a way to update it?

[Garneauma]

@bozzit You should make your changes locally. Then, you can amend your previous commit and force-push to your remote branch:

• git add .
• git commit --amend --no-edit
• git push -f origin master

[Garneauma]

@bozzit Could you please add a link from the documentation to the working example and vice-versa?

[bozzit]

So there was a link already to the configuration from index, so I added a Back link at the top of the config pages.

[Garneauma]

@bozzit Thank you for creating the documentation page and for taking the time to translate it! I have highlighted some changes to keep it consistent with the rest of the GCWeb documentation and some small typos.

Note: not mandatory, but every instance of "Table" in French should be changed to "Tableau".

[bozzit]

I think I got them all, but let me know if I missed or messed something up

[Garneauma]

@bozzit You missed a few. I have added some other ones.

[bozzit]

Maybe email me the change files ? I’ll take a look at it in the morning.

[Garneauma]

@bozzit The unresolved conversations are the only changes left to do. Please make sure to reveal hidden conversations by clicking the "Load more..." button.
Here's the list:

• Add lang="en" on French documentation table.
• Update paragraph above configuration table in both languages.
• Remove useless <div class="mrgn-bttm-lg"> wrapping the first example in both languages.

I will then do a final review, but I think that's it!

[Garneauma]

Approved! Thank you for your contribution @bozzit.

Could you please update your PR comment (the one at the top of the page) to include the following (no need to be very detailed):

• Clear and simple explanation of the new feature;
• The impact on the sponsored department;
• The impact on the public.

[bozzit]

I thought I included this in the text at the top:

DataTable Utilities, includes Data Manipulation Classes for emails, Urls and Money. Also Includes Datatable Footer Totals.

Having this plugin integrated will make the transition to Canada.ca easier as these features are already in use on https://www.tpsgc-pwgsc.gc.ca, currently some of the pages that make use of this plugin and other pages that make use of Other JavaScripts are just pointed to from Canada.ca

The Public at Large, the plugin makes DataTables more user friendly with Clickable Links, and they are used to this functionality our PRE Canada.ca Pages.

[Garneauma]

I thought I included this in the text at the top:

DataTable Utilities, includes Data Manipulation Classes for emails, Urls and Money. Also Includes Datatable Footer Totals.

Having this plugin integrated will make the transition to Canada.ca easier as these features are already in use on https://www.tpsgc-pwgsc.gc.ca, currently some of the pages that make use of this plugin and other pages that make use of Other JavaScripts are just pointed to from Canada.ca

The Public at Large, the plugin makes DataTables more user friendly with Clickable Links, and they are used to this functionality our PRE Canada.ca Pages.

Oh, that is my fault. I didn't realize the text in the documentation was meant for that. Sorry about that.