Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up: moving deprecated components to méli-mélo #2425

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

Garneauma
Copy link
Contributor

@Garneauma Garneauma commented Sep 17, 2024

This is a clean up PR to deprecate some demoted components and move some already deprecated components to the experimentation section.

The following components/templates have been deprecated:

The following components/theme have been moved to the experimentation section:

  • Chat wizard
  • Background image heading
  • Light warning alert icon
  • Pink day theme

Note: the Footer version 1 through 5 working examples have been removed from the codebase as they have been deprecated from more than a year.

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial and incomplete review, I only checked the follow-us deprecation

components/gc-follow-us/_base.scss Outdated Show resolved Hide resolved
components/gc-follow-us/_base.scss Show resolved Hide resolved
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je pensais que les fonctionnalités provisionnelles retiré seraient tous contenu dans "deprecated". La raison principal de leur déplacement c'est parce qu'il y a eu aucune action récente démontrant l'intérêt de les stabiliser officiellement.

Aussi, il faudrait écrire une petit note pour la migration des éléments deprecated.

@Garneauma Garneauma force-pushed the deprecate-demoted branch 2 times, most recently from 8aec391 to 6cb7962 Compare November 28, 2024 15:41
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review.

We will need a note that those image file are deprecated and are going to removed from our distribution.

  • x-blue-line.png

components/_provisional.scss Outdated Show resolved Hide resolved
méli-mélo/deprecated/style.css Outdated Show resolved Hide resolved
components/gc-follow-us/_base.scss Outdated Show resolved Hide resolved
méli-mélo/deprecated/assets/x-blue-line.png Outdated Show resolved Hide resolved
méli-mélo/deprecated/chatwizard/chatwizard-en.html Outdated Show resolved Hide resolved
méli-mélo/deprecated/chatwizard/chatwizard-en.html Outdated Show resolved Hide resolved
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

méli-mélo/deprecated/chatwizard/meta.md Outdated Show resolved Hide resolved
méli-mélo/deprecated/deprecated.html Show resolved Hide resolved
méli-mélo/deprecated/pinkday/docs-en.html Outdated Show resolved Hide resolved
méli-mélo/deprecated/pinkday/meta.md Outdated Show resolved Hide resolved
sites/footers/old-footers-en.html Show resolved Hide resolved
sites/footers/old-footers-en.html Outdated Show resolved Hide resolved
sites/footers/old-footers-fr.html Outdated Show resolved Hide resolved
sites/page-details/index.json-ld Outdated Show resolved Hide resolved
sites/page-details/index.json-ld Outdated Show resolved Hide resolved
sites/page-details/deprecated/page-details-v3-fr.html Outdated Show resolved Hide resolved
sites/page-details/deprecated/page-details-v3.1-en.html Outdated Show resolved Hide resolved
sites/page-details/deprecated/page-details-v3.1-fr.html Outdated Show resolved Hide resolved
templates/institutional-landing/reports/a11y-1.json Outdated Show resolved Hide resolved
templates/topic/index.json-ld Outdated Show resolved Hide resolved
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few little content adjustment and some change for the CSS copied over the deprecated css file.

components/gc-follow-us/_base.scss Outdated Show resolved Hide resolved
components/gc-follow-us/_base.scss Outdated Show resolved Hide resolved
méli-mélo/deprecated/style.css Outdated Show resolved Hide resolved
méli-mélo/deprecated/style.css Outdated Show resolved Hide resolved
méli-mélo/deprecated/style.css Outdated Show resolved Hide resolved
templates/thematic/index.json-ld Outdated Show resolved Hide resolved
templates/thematic/index.json-ld Outdated Show resolved Hide resolved
templates/thematic/index.json-ld Outdated Show resolved Hide resolved
templates/thematic/index.json-ld Outdated Show resolved Hide resolved
templates/thematic/index.json-ld Outdated Show resolved Hide resolved
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested locally. Everything look good.

@ouafaaetta note this PR do impact a lot of component/feature and provisional feature. Take the time to get the full list.

This is major change as it mark a few component as "Deprecated" and it remove the support for the old site footer which was deprecated a year and half ago.

@duboisp duboisp merged commit 51fa1ec into wet-boew:master Dec 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants