-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up: moving deprecated components to méli-mélo #2425
Conversation
e3980da
to
05dd10a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial and incomplete review, I only checked the follow-us deprecation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je pensais que les fonctionnalités provisionnelles retiré seraient tous contenu dans "deprecated". La raison principal de leur déplacement c'est parce qu'il y a eu aucune action récente démontrant l'intérêt de les stabiliser officiellement.
Aussi, il faudrait écrire une petit note pour la migration des éléments deprecated.
8aec391
to
6cb7962
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review.
We will need a note that those image file are deprecated and are going to removed from our distribution.
- x-blue-line.png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review
6cb7962
to
8d50569
Compare
8d50569
to
1e02b2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few little content adjustment and some change for the CSS copied over the deprecated css file.
1e02b2f
to
09e761e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and tested locally. Everything look good.
@ouafaaetta note this PR do impact a lot of component/feature and provisional feature. Take the time to get the full list.
This is major change as it mark a few component as "Deprecated" and it remove the support for the old site footer which was deprecated a year and half ago.
This is a clean up PR to deprecate some demoted components and move some already deprecated components to the experimentation section.
The following components/templates have been deprecated:
The following components/theme have been moved to the experimentation section:
Note: the Footer version 1 through 5 working examples have been removed from the codebase as they have been deprecated from more than a year.