Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback: deprecating RAP and Page details 2.0 #2277

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Feedback: deprecating RAP and Page details 2.0 #2277

merged 1 commit into from
Nov 16, 2023

Conversation

Garneauma
Copy link
Contributor

  • Deprecating RAP
  • Deprecating Page details 1.1 and 2.0
  • Updating code samples with correct characters

@duboisp
Copy link
Member

duboisp commented Nov 14, 2023

Pre-approved upon review and local testing.

duboisp
duboisp requested changes Nov 15, 2023
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 little change request.

Other than that its all good. I reviewed all the code and tested locally.

sites/page-details/index.json-ld Show resolved Hide resolved
sites/feedback/index.json-ld Show resolved Hide resolved
@Garneauma Garneauma force-pushed the page-feedback branch 2 times, most recently from b0127cb to c1bcd6a Compare November 15, 2023 20:17
duboisp
duboisp requested changes Nov 15, 2023
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little change because we released page-details version 3.

sites/feedback/index.json-ld Show resolved Hide resolved
@Garneauma
Copy link
Contributor Author

One little change because we released page-details version 3.

Done. Sorry, I missed that.

duboisp
duboisp approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the latest change and its all good.

@duboisp duboisp merged commit 2934f08 into wet-boew:master Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duboisp duboisp duboisp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Garneauma @duboisp