Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: header cookies design error #150

Merged
merged 1 commit into from
Jan 5, 2025
Merged

fix: header cookies design error #150

merged 1 commit into from
Jan 5, 2025

Conversation

ozline
Copy link
Member

@ozline ozline commented Jan 5, 2025

自查 PR 结构

  • PR 标题符合这个格式: <type>(optional scope): <description>

  • 此 PR 标题的描述以用户为导向,足够清晰,其他人可以理解。

  • 我已经对所有 commit 提供了签名(GPG 密钥签名、SSH 密钥签名)

  • 这个 PR 属于强制变更/破坏性更改

如果是,请在 PR 标题中添加 BREAKING CHANGE 前缀,并在 PR 描述中详细说明。

这个 PR 的类型是什么?

fix

这个 PR 做了什么 / 我们为什么需要这个 PR?

对接过程中注意到后端对 Cookies 的处理方式不符合标准逻辑,进行修改

(可选)这个 PR 解决了哪个/些 issue?

对 Reviewer 预留的一些提醒

@ozline ozline requested review from renbaoshuo, jiuxia211, mutezebra and a team as code owners January 5, 2025 16:45
@ozline ozline merged commit d210ada into main Jan 5, 2025
7 checks passed
@ozline ozline deleted the fix/header-solve branch January 5, 2025 16:46
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 11.79775% with 157 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
kitex_gen/academic/k-academic.go 0.00% 68 Missing ⚠️
kitex_gen/academic/academic.go 0.00% 44 Missing ⚠️
kitex_gen/classroom/k-classroom.go 0.00% 16 Missing ⚠️
kitex_gen/classroom/classroom.go 0.00% 8 Missing ⚠️
kitex_gen/course/k-course.go 0.00% 8 Missing ⚠️
api/handler/api/academic_service.go 0.00% 4 Missing ⚠️
kitex_gen/course/course.go 0.00% 4 Missing ⚠️
pkg/utils/utils.go 90.00% 1 Missing and 1 partial ⚠️
api/handler/api/class_room_service.go 0.00% 1 Missing ⚠️
api/handler/api/course_service.go 0.00% 1 Missing ⚠️
... and 1 more
@@           Coverage Diff            @@
##            main    #150      +/-   ##
========================================
+ Coverage   3.13%   3.16%   +0.03%     
========================================
  Files        183     184       +1     
  Lines      38472   38335     -137     
========================================
+ Hits        1205    1215      +10     
+ Misses     37203   37056     -147     
  Partials      64      64              
Flag Coverage Δ
unittest 3.16% <11.79%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ex_gen/academic/academicservice/academicservice.go 23.20% <100.00%> (ø)
kitex_gen/academic/academicservice/client.go 0.00% <ø> (ø)
kitex_gen/academic/academicservice/server.go 0.00% <ø> (ø)
...gen/classroom/classroomservice/classroomservice.go 34.93% <100.00%> (ø)
kitex_gen/classroom/classroomservice/client.go 0.00% <ø> (ø)
kitex_gen/classroom/classroomservice/server.go 0.00% <ø> (ø)
kitex_gen/course/courseservice/client.go 0.00% <ø> (ø)
kitex_gen/course/courseservice/courseservice.go 46.77% <100.00%> (ø)
kitex_gen/course/courseservice/server.go 0.00% <ø> (ø)
pkg/base/login_data/login_data.go 0.00% <ø> (ø)
... and 11 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant