Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests on version and common service, delete useless statistic #138

Merged
merged 3 commits into from
Dec 15, 2024

Conversation

FantasyRL
Copy link
Member

@FantasyRL FantasyRL commented Dec 14, 2024

自查 PR 结构

  • PR 标题符合这个格式: <type>(optional scope): <description>

  • 此 PR 标题的描述以用户为导向,足够清晰,其他人可以理解。

  • 我已经对所有 commit 提供了签名(GPG 密钥签名、SSH 密钥签名)

  • 这个 PR 属于强制变更/破坏性更改

如果是,请在 PR 标题中添加 BREAKING CHANGE 前缀,并在 PR 描述中详细说明。

这个 PR 的类型是什么?

这个 PR 做了什么 / 我们为什么需要这个 PR?

(可选)这个 PR 解决了哪个/些 issue?

对 Reviewer 预留的一些提醒

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/upyun/version.go 0.00% 9 Missing ⚠️
config/config.go 0.00% 1 Missing ⚠️
pkg/utils/check_pwd.go 0.00% 1 Missing ⚠️
@@           Coverage Diff            @@
##            main    #138      +/-   ##
========================================
+ Coverage   2.51%   2.85%   +0.34%     
========================================
  Files        179     179              
  Lines      36672   36672              
========================================
+ Hits         923    1048     +125     
+ Misses     35709   35568     -141     
- Partials      40      56      +16     
Flag Coverage Δ
unittest 2.85% <15.38%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/version/service/upload_params.go 100.00% <100.00%> (+100.00%) ⬆️
config/config.go 0.00% <0.00%> (ø)
pkg/utils/check_pwd.go 0.00% <0.00%> (ø)
pkg/upyun/version.go 0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes

@FantasyRL FantasyRL changed the title add: ci test in version , launch_screen and common add some CI tests and delete statistic Dec 14, 2024
@FantasyRL FantasyRL marked this pull request as ready for review December 14, 2024 14:38
@FantasyRL FantasyRL requested review from mutezebra, ozline, jiuxia211 and a team as code owners December 14, 2024 14:38
@FantasyRL FantasyRL removed request for a team and mutezebra December 14, 2024 14:38
@FantasyRL
Copy link
Member Author

添加了version与common的service层CI test,目前version/get_setting_test.go覆盖率没达标准,标记一下

@ozline ozline changed the title add some CI tests and delete statistic test: add tests on version and common service, delete useless statistic Dec 15, 2024
@ozline ozline merged commit 5961047 into west2-online:main Dec 15, 2024
7 checks passed
@FantasyRL FantasyRL deleted the not_main branch December 15, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants