feat: add common module #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of required
penqee
requested review from
mutezebra,
ozline,
jiuxia211 and
a team
as code owners
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #135 +/- ##
========================================
+ Coverage 3.08% 3.13% +0.05%
========================================
Files 182 183 +1
Lines 36799 38472 +1673
========================================
+ Hits 1134 1205 +71
- Misses 35601 37203 +1602
Partials 64 64
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jiuxia211
reviewed
Dec 12, 2024
internal/common/service/term.go
Outdated
| ) | ||
|
|
||
| func (s *TermService) GetTermList() (*jwch.SchoolCalendar, error) { | ||
| return jwch.NewStudent().GetSchoolCalendar() |
There was a problem hiding this comment.
仿照academic 加入对 jwch库的cookie错误的特殊处理
|
看来出现的新的冲突 |
我晚点解决一下 |
|
这只能本地手动 merge 一下 main 了 |
|
unit Test 测试过不了原因是errno那里错误信息从英文换成中文了，common这里的test我改过了，test能通过 |
jiuxia211
force-pushed
the
add_common_module
branch
from
55e5635 to
420f40b
Compare
jiuxia211
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…instead of required
Closes #68.
自查 PR 结构
PR 标题符合这个格式: <type>(optional scope): <description>
此 PR 标题的描述以用户为导向，足够清晰，其他人可以理解。
我已经对所有 commit 提供了签名（GPG 密钥签名、SSH 密钥签名）
这个 PR 属于强制变更/破坏性更改
这个 PR 的类型是什么？
这个 PR 做了什么 / 我们为什么需要这个 PR？
主要是对#68做一些补充
(可选)这个 PR 解决了哪个/些 issue？
对 Reviewer 预留的一些提醒