feat: dark mode support #52
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 11 out of 26 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- app/toolbox/academic/index.tsx: Evaluated as low risk
- app/toolbox/academic/gpa.tsx: Evaluated as low risk
- app/+not-found.tsx: Evaluated as low risk
- app/(tabs)/_layout.tsx: Evaluated as low risk
- app/toolbox/academic/unified-exam.tsx: Evaluated as low risk
- app/(tabs)/qrcode.tsx: Evaluated as low risk
- app/(tabs)/toolbox.tsx: Evaluated as low risk
- app/(guest)/about.tsx: Evaluated as low risk
- app/toolbox/jiaxi-lecture.tsx: Evaluated as low risk
- app/devtools/push-tools.tsx: Evaluated as low risk
- app/toolbox/academic/grades.tsx: Evaluated as low risk
- app/toolbox/exam-room.tsx: Evaluated as low risk
- app/toolbox/empty-room.tsx: Evaluated as low risk
- app/toolbox/academic/credits.tsx: Evaluated as low risk
- app/devtools/index.tsx: Evaluated as low risk
|
突然想起来好像开屏页部分没有做深色模式？ |
|
不用做强制切换，iOS 侧除了国产 app 基本都是跟随系统 |
|
这个 pr 待课表（#14）合入后再调整，目前已知存在问题的有
|
|
强制切换要做，可以后面再加。之前的自定义皮肤是基于深色模式的，可以参考一下 |
自定义皮肤感觉又要变成一个巨坑了……？ |
本来就是，我反正不用自定义皮肤，但原来做的就不够好，但用户可以自适应，他们会选择比较容易看得清楚的壁纸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
目前只是跟随系统，是否提供强制切换还有待商榷。
演示视频：
bandicam.2025-02-03.18-08-59-432.mp4
部分细节还需处理，等待组内美工介入。