Generalize test infrastructure a bit #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we had logic in place that for every tests tried to guess which exceptions were expected, given the test configuration. This was a bit limiting however; it's easier to just put this logic in the tests themselves. We make that change in this PR, which will make the _next_ PR a bit easier.
edsko
force-pushed
the
edsko/generalize-tests
branch
from
6272104 to
541039f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had logic in place that for every tests tried to guess which exceptions were expected, given the test configuration. This was a bit limiting however; it's easier to just put this logic in the tests themselves. We make that change in this PR, which will make the next PR a bit easier.