Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnboxedTuples to Generics/SOP/Instances.hs #167

Closed
wants to merge 1 commit into from

Conversation

monoidal
Copy link

GHC commit ghc/ghc@fbe3fe003ac8d4a06 changed the type CodeBuffers to an unboxed tuple. As a result, generics-sop needs an extension to compile on head:

src/Generics/SOP/Instances.hs:298:1: error: [GHC-19590]
    • Illegal unboxed tuple type as function argument:
      (# State# RealWorld, CodingProgress, Buffer from, Buffer to #)
    • In the expansion of type synonym ‘GHC.IO.Encoding.Types.CodeBuffer#’
      In the type instance declaration for ‘Generics.SOP.Universe.Code’
      In the instance declaration for
        ‘Generics.SOP.Universe.Generic (BufferCodec from_ap4y to_ap4z state_ap4A)’
    Suggested fix: Perhaps you intended to use UnboxedTuples
    |
298 | deriveGeneric ''BufferCodec -- new
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^

GHC commit fbe3fe003ac8d4a06 changed the type
CodeBuffers to an unboxed tuple. As a result,
generics-sop needs an extension to compile on head.
@monoidal
Copy link
Author

Superseded by #173

@monoidal monoidal closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant